Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyzer for leap #1532

Open
kytrinyx opened this issue Apr 27, 2023 · 2 comments
Open

Add analyzer for leap #1532

kytrinyx opened this issue Apr 27, 2023 · 2 comments

Comments

@kytrinyx
Copy link
Member

We have some logic in the leap test suite that ensures that people don't use the built-in functions from Date.

Since the instructions don't say anything about not using built in functions (see https://github.com/exercism/ruby/blob/main/exercises/practice/leap/.docs/instructions.md), we should create an analyzer for this functionality.

@kotp
Copy link
Member

kotp commented Apr 27, 2023

Alternative middle step may be the add the mention in the documentation, as an append.

I would be as delighted, though, to see a refinement on the Date class, as much as a "not Date class" solution. I believe an analyzer could detect if the built in method from Date is used, but the tests likely can not.

@kytrinyx
Copy link
Member Author

Alternative middle step may be the add the mention in the documentation, as an append.

That would work, too.

I would be as delighted, though, to see a refinement on the Date class, as much as a "not Date class" solution. I believe an analyzer could detect if the built in method from Date is used, but the tests likely can not.

Agreed. I think an analyzer would be a really nice improvement for this exercise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants