From e3e2f060ceaa93e453ec2fc810e6257fab2baaed Mon Sep 17 00:00:00 2001 From: Newters Date: Wed, 25 Sep 2024 17:17:21 +1000 Subject: [PATCH 1/2] changed secret.add values to avoid further confusion --- exercises/concept/secrets/.docs/instructions.md | 4 ++-- exercises/concept/secrets/test/secrets_test.exs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exercises/concept/secrets/.docs/instructions.md b/exercises/concept/secrets/.docs/instructions.md index b7ccb6872a..c7dd13d79c 100644 --- a/exercises/concept/secrets/.docs/instructions.md +++ b/exercises/concept/secrets/.docs/instructions.md @@ -11,9 +11,9 @@ All functions should expect integer arguments. Integers are also suitable for pe Implement `Secrets.secret_add/1`. It should return a function which takes one argument and adds to it the argument passed in to `secret_add`. ```elixir -adder = Secrets.secret_add(2) +adder = Secrets.secret_add(3) adder.(2) -# => 4 +# => 5 ``` ## 2. Create a subtractor diff --git a/exercises/concept/secrets/test/secrets_test.exs b/exercises/concept/secrets/test/secrets_test.exs index 04b51fcb20..b01286ff0f 100644 --- a/exercises/concept/secrets/test/secrets_test.exs +++ b/exercises/concept/secrets/test/secrets_test.exs @@ -4,8 +4,8 @@ defmodule SecretsTest do describe "secret_add" do @tag task_id: 1 test "add 3" do - add = Secrets.secret_add(3) - assert add.(3) === 6 + add = Secrets.secret_add(4) + assert add.(3) === 7 end @tag task_id: 1 From d52bec1d5f54a5983ca6d3b1fabc9d599be62a04 Mon Sep 17 00:00:00 2001 From: Angelika Cathor Date: Wed, 25 Sep 2024 14:38:40 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- exercises/concept/secrets/test/secrets_test.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exercises/concept/secrets/test/secrets_test.exs b/exercises/concept/secrets/test/secrets_test.exs index b01286ff0f..d7160742f8 100644 --- a/exercises/concept/secrets/test/secrets_test.exs +++ b/exercises/concept/secrets/test/secrets_test.exs @@ -3,7 +3,7 @@ defmodule SecretsTest do describe "secret_add" do @tag task_id: 1 - test "add 3" do + test "add 4" do add = Secrets.secret_add(4) assert add.(3) === 7 end