Skip to content

Commit 0a1ccad

Browse files
committed
🧪 TEST: normalize translatable attrs, add issue extlink
- add 'translatable'/'translated' to the boolean-attribute normalization list, so regressions are stable across docutils 0.22 (1/0) and earlier (True/False) serializations - define an 'issue' extlink for changelog references
1 parent 9b26f54 commit 0a1ccad

5 files changed

Lines changed: 21 additions & 12 deletions

File tree

‎docs/conf.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,10 @@
2323

2424
extlinks = {
2525
"pr": ("https://github.com/executablebooks/sphinx-design/pull/%s", "PR #%s"),
26+
"issue": (
27+
"https://github.com/executablebooks/sphinx-design/issues/%s",
28+
"#%s",
29+
),
2630
"user": ("https://github.com/%s", "@%s"),
2731
}
2832

‎tests/conftest.py‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,8 @@ def _normalize(text: str) -> str:
122122
"refexplicit",
123123
"refwarn",
124124
"selected",
125+
"translatable",
126+
"translated",
125127
]
126128
text = re.sub(rf' ({"|".join(attrs)})="1"', r' \1="True"', text)
127129
text = re.sub(rf' ({"|".join(attrs)})="0"', r' \1="False"', text)

‎tests/test_misc.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,11 @@ def test_tab_set_with_paragraph_warns(sphinx_builder):
345345
builder.build(assert_pass=False)
346346
assert "All children of a 'tab-set' should be 'tab-item'" in builder.warnings
347347
assert "[design.tab]" in builder.warnings
348+
349+
348350
I18N_INDEX_RST = """\
349351
Heading
352+
=======
350353
351354
.. _target-section:
352355

‎tests/test_snippets/snippet_post_button-link.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,27 @@
22
<section ids="heading" names="heading">
33
<title>
44
Heading
5-
<paragraph translatable="0">
5+
<paragraph translatable="False">
66
<reference classes="sd-sphinx-override sd-btn sd-text-wrap" refuri="https://example.com">
77
<inline>
88
https://example.com
9-
<paragraph translatable="0">
9+
<paragraph translatable="False">
1010
<reference classes="sd-sphinx-override sd-btn sd-text-wrap" refuri="https://example.com">
1111
<inline>
1212
Button text
13-
<paragraph translatable="0">
13+
<paragraph translatable="False">
1414
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-primary" refuri="https://example.com">
1515
<inline>
1616
Button text with options
17-
<paragraph translatable="0">
17+
<paragraph translatable="False">
1818
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-primary sd-shadow-sm" refuri="https://example.com">
1919
<inline>
2020
https://example.com
21-
<paragraph translatable="0">
21+
<paragraph translatable="False">
2222
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-outline-primary" refuri="https://example.com">
2323
<inline>
2424
https://example.com
25-
<paragraph translatable="0">
25+
<paragraph translatable="False">
2626
<inline classes="sd-d-grid">
2727
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-secondary" refuri="https://example.com">
2828
<inline>

‎tests/test_snippets/snippet_pre_button-link.xml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,27 @@
22
<section ids="heading" names="heading">
33
<title>
44
Heading
5-
<paragraph translatable="0">
5+
<paragraph translatable="False">
66
<reference classes="sd-sphinx-override sd-btn sd-text-wrap" refuri="https://example.com">
77
<inline>
88
https://example.com
9-
<paragraph translatable="0">
9+
<paragraph translatable="False">
1010
<reference classes="sd-sphinx-override sd-btn sd-text-wrap" refuri="https://example.com">
1111
<inline>
1212
Button text
13-
<paragraph translatable="0">
13+
<paragraph translatable="False">
1414
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-primary" refuri="https://example.com">
1515
<inline>
1616
Button text with options
17-
<paragraph translatable="0">
17+
<paragraph translatable="False">
1818
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-primary sd-shadow-sm" refuri="https://example.com">
1919
<inline>
2020
https://example.com
21-
<paragraph translatable="0">
21+
<paragraph translatable="False">
2222
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-outline-primary" refuri="https://example.com">
2323
<inline>
2424
https://example.com
25-
<paragraph translatable="0">
25+
<paragraph translatable="False">
2626
<inline classes="sd-d-grid">
2727
<reference classes="sd-sphinx-override sd-btn sd-text-wrap sd-btn-secondary" refuri="https://example.com">
2828
<inline>

0 commit comments

Comments
 (0)