From 85a7e9cc75b37a212ea790fd496e804432903d1f Mon Sep 17 00:00:00 2001 From: Erik Onarheim Date: Mon, 5 Feb 2024 23:08:42 -0600 Subject: [PATCH] fix: update uvPadding default when antialiasing: false or ImageFiltering.Pixel --- src/engine/Engine.ts | 10 +++++++++- .../GraphicsSystemSpec/graphics-system.png | Bin 1196 -> 1096 bytes 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/engine/Engine.ts b/src/engine/Engine.ts index 487328dc3..e903f4bb6 100644 --- a/src/engine/Engine.ts +++ b/src/engine/Engine.ts @@ -165,7 +165,10 @@ export interface EngineOptions { * Specify any UV padding you want use in pixels, this brings sampling into the texture if you're using * a sprite sheet in one image to prevent sampling bleed. * - * By default .01 pixels, and .25 pixels if `pixelArt: true` + * Defaults: + * * `antialiasing: false` or `filtering: ImageFiltering.Pixel` - 0.0; + * * `pixelArt: true` - 0.25 + * * All else 0.01 */ uvPadding?: number; @@ -819,6 +822,11 @@ O|===|* >________________>\n\ if (options.pixelArt) { uvPadding = .25; } + + if (!options.antialiasing || filtering === ImageFiltering.Pixel) { + uvPadding = 0; + } + // Override with any user option, if non default to .25 for pixel art, 0.01 for everything else uvPadding = options.uvPadding ?? uvPadding ?? 0.01; diff --git a/src/spec/images/GraphicsSystemSpec/graphics-system.png b/src/spec/images/GraphicsSystemSpec/graphics-system.png index 72fe3ccdac09260daef37dcb698c06f166439480..3814e5ef1eb406f94a6768178e2fb15a5bae77a6 100644 GIT binary patch delta 1062 zcmV+>1ljwn3CIYLF@FL{L_t(|UhUmIOcX&B2k?g>nzJFn(RgMa?X%*<9{p-t4@+7v{eW z&CJ}~|95X@_jWJzOx#)iOMBp0xp8U_ybGcpfar1rh%OIQh<`Em& zSP*FpSCk+@vVX#GK?x2dYYZ+*P$1pH;GhHp(rpY|6o6RV5AoTg)4h~nKuoCJu98j| z(Huj2ajeO~weAIsYhc3dkZZDpWB+I%j!D1W{%u&H}M@rePD4y$LUO7V>W z5R2^$4_jM=)TD{GO}*L6khmZ*MYo$3SY zQOn+MBhYMBY5F+}M`%cyAS${IiRGPz7N&eYA+E+W|JPbgHXl?c) zZ6B*RhnVbWP=+7PIgb@QNSbA;RqAP$ub@H9#%-1=iNjQh%SInGNOh(}wXwGn9ubDi z(iJR-*}&IImqak)K}Y8wv#(Qv1=%c?X{%Tk1v&cS8XbN;&3cVsK_r)}SRl80nuZ_F z1AoLOfzMaZQ+=Rn)6}_*`C7#+Tbv`<3i-JEpMN-ExwM^N{%0Y8xTMVJ0}#uwGFh@V z3N$+R#BxSE&4R5EZ0fAfiF{+6_R43>dIek?Jh$6TlUEG$xO{7v*!O8gK+-$o%? zk`7kRMF@CM&e!^+bR1NOG8ljWL|FpLrh^Irh_VEfO$QYM5M>D{n+_@jAj%R@HXj{S g2tbr2plmw-09xi;`5-(|t^fc407*qoM6N<$f_ggSS^xk5 delta 1163 zcmV;61a$kz2&@T^F@I)BL_t(|UhUmYXcIvc2k^H=LgEK0f~K|5TEVIZL9BYJpl9n{ z+nXO1JbO_=QBY5Mw)Nvy_0p3bJ@n91wNmh)R;ad8`*pBIr6H88Y|?}flk9twnaR@m z7fLU0W;g#|W_BmDC0^&fNuM^s&-BeBo8VOtc>sx)BS50%fqxMaF%N(M#83jbs2d7a zwOfFwCTFM}K$yW!-^i~I_T8Ukwooer2qU)wMxoRs3P3_Y$}vo%0Hg*;H4Kv|0I32J zhG7Z?AQeEk7$#5vQU)T$(2W9+5)f4kohSg=NV8rHT_^w{B3&3dP@D(RjZrU((;%iW z>OpZ9#59H~ihq+JwlGvsoCC3qAw_Wtq)`|W6lXvhjlo3$2xC7)XGz#ziZdWVsEr;a zVHmk{bnVH-Mxk&poCImaNa12Q3t|&Rg5flX4HPMc^B^WsR4@Rdc`t;!)~IzG?c7~f zwJ>zueW{L&!g&D%Tev#cy~Vz?{lkvxNU3*ZV1(3oUw=qZbYbA4t^q|S20%h)&#;lA z8v`JW%NZWFW`tCsMB7EZ(&6#%2yzsoAf+pM6Vp`b%f&iGj&HODK#ayK?;IfV%#5}G zh|zfEodZOknb8&iF&eMDbAZS*Gui?mM&p%t4iI@}Xu(Lp_)48|4k#%}03Z>2I{*YA z5lbLqr++;8x+Wpz*PH$Kx%+rFNn*y2I0FaRk9@qAkAct3`4R*DQ$gqU|5g(yljmi2Np{_QliK zEZ-kePYT(@D$Vx|P$u=Io^B`@Evb=*)U=jV?gt~p%hKG%bClUVr5s{u!vLjqcu0Aq zxDDd@wA_13d77#wn4iAxDqT~Y23gxXP78elT1G~BCoM0ADDnM-xNmnsJfG(KFHyRE zLVp|@r$K(|dLkYr&VpoGKGEET^PFszYucW_q}akCQF}K*JfD7@d`v4ngQBpc#XH|# zqvUu$5%E{_&Vrbnt_pDR*=}kbekz)_90keJkE>^BJvlFZ(~Ih3iw7u}wj_&1XF@RwQEw;3$AAXe8&|=oXdb(Q$AI)o{J(I_J%1?I zHJW=qD;xh^oX%oPUDTA`L0hLzQ)0Fo56T&ZDDS-1qolc~OZgj5-1Ejootu=UI)GRT zntK?4aFeoB2M|j^a}NU$Zc>)&0AeX