From 3c820feb2ed1adcff9c3121f6d52cbb59b225bc4 Mon Sep 17 00:00:00 2001 From: Erik Onarheim Date: Thu, 4 Jan 2024 08:44:52 -0600 Subject: [PATCH] fix: Prevent debug draw of non-solid Isometric tiles --- CHANGELOG.md | 1 + src/engine/TileMap/IsometricMap.ts | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b035df4c1..8a811de32 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed +- Fixed issue where `IsometricMap` would debug draw collision geometry on non-solid tiles - Fixed issue where `CompositeCollider` offset was undefined if not set - Fixed Actor so it receives `predraw`/`postdraw` events per the advertised strongly typed events - Fixed infinite loop :bomb: when certain degenerate polygons were attempted to be triangulated! diff --git a/src/engine/TileMap/IsometricMap.ts b/src/engine/TileMap/IsometricMap.ts index abe8b42a3..602833099 100644 --- a/src/engine/TileMap/IsometricMap.ts +++ b/src/engine/TileMap/IsometricMap.ts @@ -474,8 +474,10 @@ export class IsometricMap extends Entity { } if (showAll || showColliderGeometry) { for (const tile of this.tiles) { - for (const collider of tile.getColliders()) { - collider.debug(gfx, geometryColor, { lineWidth: geometryLineWidth, pointSize: geometryPointSize }); + if (tile.solid) { // only draw solid tiles + for (const collider of tile.getColliders()) { + collider.debug(gfx, geometryColor, { lineWidth: geometryLineWidth, pointSize: geometryPointSize }); + } } } }