URL validation is incorrect

[2shrestha22]

The URL validation implementation is incorrect and always return valid for any string.

Current implementation:

    final uri = Uri.tryParse(value);
    if (uri != null && allowedSchemes != null) {
      return allowedSchemes!.contains(uri.scheme);
    }
    return uri != null;

But only checking url!=null is not sufficient since. URI.tryParse() does not return null for example, hello, iamnotavalidurl etc.

[2shrestha22]

More reference here: https://stackoverflow.com/questions/52975739/dart-flutter-validating-a-string-for-url

[exaby73]

Hello @2shrestha22. This is a URI validator, not a URL validator. I guess we can add a specific URL validator as well. Let me know your thoughts

[exaby73]

Also, would you say that having a valid scheme and host is sufficient for your use case?

[2shrestha22]

Also, would you say that having a valid scheme and host is sufficient for your use case?

Yeah I think that will be sufficient.

[exaby73]

I'd like a review from you on #103 :)

[exaby73]

After merging, I'll release a new version

[2shrestha22]

Looks good to me.

[exaby73]

Release 0.5.3 🥳