-
-
Notifications
You must be signed in to change notification settings - Fork 898
Explicit Demo Mode #18946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@chrispi68 GitHub bot closes issues after a certain amount of inactivity to keep our issues clean. That's why it was closed. We're planning to do this. That's why I've reopened and added the And yes, like @Maschga says. What you're describing should definitely work today. Please open a discussion with more details. |
@naltatis I've started exploring this. If nobody else is working on this, you can assign it to me. Question on the "disable config ui" -> I intend to do this by disabling the "editing" buttons client side. Basically the client will know that it is running in demo mode. This way, you can still see the configuration page. Is that what you intended? Do you think it is important to also disable the api on the server side? For "disable restart", I think both server and client side should disable that functionality to avoid accidents, does that make sense? |
If you want to have a peek at size of the code changes, review here: https://github.com/guido4096/evcc/tree/explicit-demo-mode |
Hi @guido4096, thanks for working on this. I've looked through your PoC commit and it looks good so far. I have some remarks like how to publish if we are in demo or not, but I'll post that once you've opened a PR here.
We should definitely disable the features server-side. For use-cases like the demo.evcc.io we dont want people modify the configuration. I'd remove the config ui page in demo mode completely. At least in the first iteration. I see that having a read-only mode would be nice for new users to explore all the toggles and switches, but this is not trivial and would require quite a bite of change. Generally I'd say everything that is auth-protected right now should be disabled in demo mode. We could introduce a dedicated status code or message similar to 401 unauthorized (triggers login modal) that triggers a "not available in demo mode" message. |
Uh oh!
There was an error while loading. Please reload this page.
evcc enters Demo Mode when no
evcc.config
was found. Currently it's possible to add devices via Config UI in Demo Mode, which leads to a wired mixed setup.Wanted behavior:
--demo
)evcc.yaml
Note: Update documentations and demo instance accordingly
The text was updated successfully, but these errors were encountered: