forked from llm-d/llm-d-autoscaling
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathmain.go
More file actions
482 lines (417 loc) · 18.7 KB
/
Copy pathmain.go
File metadata and controls
482 lines (417 loc) · 18.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
/*
Copyright 2025.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package main
import (
"context"
"crypto/tls"
goflag "flag"
"os"
"path/filepath"
"time"
// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
// to ensure that exec-entrypoint and run can make use of them.
_ "k8s.io/client-go/plugin/pkg/client/auth"
flag "github.com/spf13/pflag"
"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/cache"
"sigs.k8s.io/controller-runtime/pkg/certwatcher"
"sigs.k8s.io/controller-runtime/pkg/healthz"
ctrlzap "sigs.k8s.io/controller-runtime/pkg/log/zap"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/metrics/filters"
metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
"sigs.k8s.io/controller-runtime/pkg/webhook"
llmdVariantAutoscalingV1alpha1 "github.com/llm-d-incubation/workload-variant-autoscaler/api/v1alpha1"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/collector/source"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/collector/source/prometheus"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/config"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/controller"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/datastore"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/engines/saturation"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/engines/scalefromzero"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/logging"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/metrics"
"github.com/llm-d-incubation/workload-variant-autoscaler/internal/utils"
poolutil "github.com/llm-d-incubation/workload-variant-autoscaler/internal/utils/pool"
promoperator "github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1"
"github.com/prometheus/client_golang/api"
promv1 "github.com/prometheus/client_golang/api/prometheus/v1"
crmetrics "sigs.k8s.io/controller-runtime/pkg/metrics"
inferencePoolV1 "sigs.k8s.io/gateway-api-inference-extension/api/v1"
inferencePoolV1alpha2 "sigs.k8s.io/gateway-api-inference-extension/apix/v1alpha2"
//+kubebuilder:scaffold:imports
)
var (
scheme = runtime.NewScheme()
)
func init() {
utilruntime.Must(clientgoscheme.AddToScheme(scheme))
utilruntime.Must(llmdVariantAutoscalingV1alpha1.AddToScheme(scheme))
utilruntime.Must(promoperator.AddToScheme(scheme))
utilruntime.Must(inferencePoolV1.Install(scheme))
utilruntime.Must(inferencePoolV1alpha2.Install(scheme))
//+kubebuilder:scaffold:scheme
}
// nolint:gocyclo
func main() {
// Server and certificate configuration
var (
metricsAddr string
probeAddr string
metricsCertPath, metricsCertName, metricsCertKey string
webhookCertPath, webhookCertName, webhookCertKey string
watchNamespace string
)
// Leader election configuration
var (
enableLeaderElection bool
leaseDuration time.Duration
renewDeadline time.Duration
retryPeriod time.Duration
restTimeout time.Duration
)
// Feature flags
var (
secureMetrics bool
enableHTTP2 bool
)
// Other
var tlsOpts []func(*tls.Config)
var loggerVerbosity int
flag.StringVar(&metricsAddr, "metrics-bind-address", "0", "The address the metrics endpoint binds to. "+
"Use :8443 for HTTPS or :8080 for HTTP, or leave as 0 to disable the metrics service.")
flag.StringVar(&probeAddr, "health-probe-bind-address", ":8081", "The address the probe endpoint binds to.")
flag.BoolVar(&enableLeaderElection, "leader-elect", false,
"Enable leader election for controller manager. "+
"Enabling this will ensure there is only one active controller manager.")
flag.BoolVar(&secureMetrics, "metrics-secure", true,
"If set, the metrics endpoint is served securely via HTTPS. Use --metrics-secure=false to use HTTP instead.")
flag.StringVar(&webhookCertPath, "webhook-cert-path", "", "The directory that contains the webhook certificate.")
flag.StringVar(&webhookCertName, "webhook-cert-name", "tls.crt", "The name of the webhook certificate file.")
flag.StringVar(&webhookCertKey, "webhook-cert-key", "tls.key", "The name of the webhook key file.")
flag.StringVar(&metricsCertPath, "metrics-cert-path", "",
"The directory that contains the metrics server certificate.")
flag.StringVar(&metricsCertName, "metrics-cert-name", "tls.crt", "The name of the metrics server certificate file.")
flag.StringVar(&metricsCertKey, "metrics-cert-key", "tls.key", "The name of the metrics key file.")
flag.BoolVar(&enableHTTP2, "enable-http2", false,
"If set, HTTP/2 will be enabled for the metrics and webhook servers")
flag.StringVar(&watchNamespace, "watch-namespace", "",
"Namespace to watch for updates. If unspecified, all namespaces are watched.")
flag.IntVar(&loggerVerbosity, "v", logging.DEFAULT, "number for the log level verbosity")
// Leader election timeout configuration flags
// These can be overridden in manager.yaml to tune for different environments
// (e.g., higher values for environments with network latency or API server slowness)
flag.DurationVar(&leaseDuration, "leader-election-lease-duration", 60*time.Second,
"The duration that non-leader candidates will wait to force acquire leadership. "+
"Increased from default 15s to 60s to prevent lease renewal failures in environments with network latency.")
flag.DurationVar(&renewDeadline, "leader-election-renew-deadline", 50*time.Second,
"The duration that the acting master will retry refreshing leadership before giving up. "+
"Increased from default 10s to 50s to provide more tolerance for network latency and API server delays.")
flag.DurationVar(&retryPeriod, "leader-election-retry-period", 10*time.Second,
"The duration the clients should wait between tries of actions. "+
"Increased from default 2s to 10s to reduce API server load and provide more time between renewal attempts.")
flag.DurationVar(&restTimeout, "rest-client-timeout", 60*time.Second,
"The timeout for REST API calls to the Kubernetes API server. "+
"Increased from default ~30s to 60s for better resilience against network latency.")
opts := ctrlzap.Options{
Development: true,
}
gfs := goflag.NewFlagSet("zap", goflag.ExitOnError)
opts.BindFlags(gfs) // zap expects a standard Go FlagSet and pflag.FlagSet is not compatible.
flag.CommandLine.AddGoFlagSet(gfs)
flag.Parse()
logging.InitLogging(&opts, &loggerVerbosity)
defer logging.Sync() // nolint:errcheck
setupLog := ctrl.Log.WithName("setup")
setupLog.Info("Logger initialized")
// if the enable-http2 flag is false (the default), http/2 should be disabled
// due to its vulnerabilities. More specifically, disabling http/2 will
// prevent from being vulnerable to the HTTP/2 Stream Cancellation and
// Rapid Reset CVEs. For more information see:
// - https://github.com/advisories/GHSA-qppj-fm5r-hxr3
// - https://github.com/advisories/GHSA-4374-p667-p6c8
disableHTTP2 := func(c *tls.Config) {
setupLog.Info("disabling http/2")
c.NextProtos = []string{"http/1.1"}
}
if !enableHTTP2 {
tlsOpts = append(tlsOpts, disableHTTP2)
}
// Create watchers for metrics and webhooks certificates
var metricsCertWatcher, webhookCertWatcher *certwatcher.CertWatcher
// Initial webhook TLS options
webhookTLSOpts := tlsOpts
if len(webhookCertPath) > 0 {
setupLog.Info("Initializing webhook certificate watcher using provided certificates",
"webhookCertPath", webhookCertPath,
"webhookCertName", webhookCertName,
"webhookCertKey", webhookCertKey)
var err error
webhookCertWatcher, err = certwatcher.New(
filepath.Join(webhookCertPath, webhookCertName),
filepath.Join(webhookCertPath, webhookCertKey),
)
if err != nil {
setupLog.Error(err, "Failed to initialize webhook certificate watcher")
os.Exit(1)
}
webhookTLSOpts = append(webhookTLSOpts, func(config *tls.Config) {
config.GetCertificate = webhookCertWatcher.GetCertificate
})
}
webhookServer := webhook.NewServer(webhook.Options{
TLSOpts: webhookTLSOpts,
})
// Metrics endpoint is enabled in 'config/default/kustomization.yaml'. The Metrics options configure the server.
// More info:
// - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.20.4/pkg/metrics/server
// - https://book.kubebuilder.io/reference/metrics.html
metricsServerOptions := metricsserver.Options{
BindAddress: metricsAddr,
SecureServing: secureMetrics,
TLSOpts: tlsOpts,
}
if secureMetrics {
// FilterProvider is used to protect the metrics endpoint with authn/authz.
// These configurations ensure that only authorized users and service accounts
// can access the metrics endpoint. The RBAC are configured in 'config/rbac/kustomization.yaml'. More info:
// https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.20.4/pkg/metrics/filters#WithAuthenticationAndAuthorization
metricsServerOptions.FilterProvider = filters.WithAuthenticationAndAuthorization
}
// If the certificate is not specified, controller-runtime will automatically
// generate self-signed certificates for the metrics server. While convenient for development and testing,
// this setup is not recommended for production.
//
// TODO(user): If you enable certManager, uncomment the following lines:
// - [METRICS-WITH-CERTS] at config/default/kustomization.yaml to generate and use certificates
// managed by cert-manager for the metrics server.
// - [PROMETHEUS-WITH-CERTS] at config/prometheus/kustomization.yaml for TLS certification.
if len(metricsCertPath) > 0 {
setupLog.Info("Initializing metrics certificate watcher using provided certificates",
"metricsCertPath", metricsCertPath,
"metricsCertName", metricsCertName,
"metricsCertKey", metricsCertKey,
)
var err error
metricsCertWatcher, err = certwatcher.New(
filepath.Join(metricsCertPath, metricsCertName),
filepath.Join(metricsCertPath, metricsCertKey),
)
if err != nil {
setupLog.Error(err, "Failed to initialize metrics certificate watcher")
os.Exit(1)
}
metricsServerOptions.TLSOpts = append(metricsServerOptions.TLSOpts, func(config *tls.Config) {
config.GetCertificate = metricsCertWatcher.GetCertificate
})
}
// --- Setup Datastore ---
ds := datastore.NewDatastore()
// Get REST config and configure timeouts to handle network latency
// This addresses issues with leader election lease renewal failures in environments
// with higher network latency or API server slowness.
restConfig := ctrl.GetConfigOrDie()
// Use configurable REST client timeout (default 60s, can be overridden via --rest-client-timeout flag)
restConfig.Timeout = restTimeout
// Configure leader election with configurable timeouts to prevent lease renewal failures
// Default values are: LeaseDuration=60s, RenewDeadline=50s, RetryPeriod=10s
// These can be overridden via command-line flags in manager.yaml
// Increased from controller-runtime defaults (15s, 10s, 2s) to provide more tolerance
// for network latency and API server delays
mgrOptions := ctrl.Options{
Scheme: scheme,
Metrics: metricsServerOptions,
WebhookServer: webhookServer,
HealthProbeBindAddress: probeAddr,
LeaderElection: enableLeaderElection,
LeaderElectionID: "72dd1cf1.llm-d.ai",
// Leader election timeout configuration (configurable via flags)
LeaseDuration: &leaseDuration,
RenewDeadline: &renewDeadline,
RetryPeriod: &retryPeriod,
// LeaderElectionReleaseOnCancel defines if the leader should step down voluntarily
// when the Manager ends. This requires the binary to immediately end when the
// Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
// speeds up voluntary leader transitions as the new leader don't have to wait
// LeaseDuration time first.
//
// This is safe to enable because the program ends immediately after the manager stops
// (see mgr.Start() call at the end of main()). This enables fast failover during
// deployments and upgrades, reducing downtime from ~60s to ~1-2s.
LeaderElectionReleaseOnCancel: true,
}
if watchNamespace != "" {
setupLog.Info("Watching single namespace", "namespace", watchNamespace)
mgrOptions.Cache = cache.Options{
DefaultNamespaces: map[string]cache.Config{
watchNamespace: {},
},
}
}
mgr, err := ctrl.NewManager(restConfig, mgrOptions)
if err != nil {
setupLog.Error(err, "unable to start manager")
os.Exit(1)
}
// Initialize metrics
setupLog.Info("Creating metrics emitter instance")
// Force initialization of metrics by creating a metrics emitter
_ = metrics.NewMetricsEmitter()
setupLog.Info("Metrics emitter created successfully")
// Configure Prometheus client using flexible configuration with TLS support
promConfig, err := config.GetPrometheusConfig(context.Background(), mgr.GetClient())
if err != nil {
setupLog.Error(err, "failed to get Prometheus configuration")
os.Exit(1)
}
// ensure we have a valid configuration
if promConfig == nil {
setupLog.Error(nil, "no Prometheus configuration found - this should not happen")
os.Exit(1)
}
// Always validate TLS configuration since HTTPS is required
if err := utils.ValidateTLSConfig(promConfig); err != nil {
setupLog.Error(err, "TLS configuration validation failed - HTTPS is required")
os.Exit(1)
}
setupLog.Info("Initializing Prometheus client",
"address", promConfig.BaseURL,
"tlsEnabled", true,
)
// Create Prometheus client with TLS support
promClientConfig, err := utils.CreatePrometheusClientConfig(promConfig)
if err != nil {
setupLog.Error(err, "failed to create prometheus client config")
os.Exit(1)
}
promClient, err := api.NewClient(*promClientConfig)
if err != nil {
setupLog.Error(err, "failed to create prometheus client")
os.Exit(1)
}
promAPI := promv1.NewAPI(promClient)
// Validate that the API is working by testing a simple query with retry logic
if err := utils.ValidatePrometheusAPI(context.Background(), promAPI); err != nil {
setupLog.Error(err, "CRITICAL: Failed to connect to Prometheus - WVA requires Prometheus connectivity for autoscaling decisions")
os.Exit(1)
}
setupLog.Info("Prometheus client and API wrapper initialized and validated successfully")
// Register optimization engine loops with the manager. Only start when leader.
err = mgr.Add(manager.RunnableFunc(func(ctx context.Context) error {
sourceRegistry := source.NewSourceRegistry()
setupLog.Info("Initializing metrics source registry")
// Read Prometheus cache configuration from ConfigMap
// TODO(LV): Uncomment and implement cache configuration reading
// cacheConfig, err := config.ReadPrometheusCacheConfig(context.Background(), mgr.GetClient())
// if err != nil {
// setupLog.Error(err, "Failed to read Prometheus cache config from ConfigMap, using defaults")
// cacheConfig = nil // Use defaults
// }
// Register PrometheusSource with default config
promSource := prometheus.NewPrometheusSource(ctx, promAPI, prometheus.DefaultPrometheusSourceConfig())
// Register in global source registry
if err := sourceRegistry.Register("prometheus", promSource); err != nil {
setupLog.Error(err, "failed to register prometheus source in source registry")
os.Exit(1)
}
engine := saturation.NewEngine(
mgr.GetClient(),
mgr.GetScheme(),
mgr.GetEventRecorderFor("workload-variant-autoscaler-saturation-engine"),
sourceRegistry,
)
go engine.StartOptimizeLoop(ctx)
return nil
}))
if err != nil {
setupLog.Error(err, "unable to add optimization engine loop to manager")
os.Exit(1)
}
// Register scale from zero engine loop with the manager. Only start when leader.
err = mgr.Add(manager.RunnableFunc(func(ctx context.Context) error {
engine, err := scalefromzero.NewEngine(mgr.GetClient(), mgr.GetRESTMapper(), restConfig, ds)
if err != nil {
return err
}
go engine.StartOptimizeLoop(ctx)
return nil
}))
if err != nil {
setupLog.Error(err, "unable to add optimization engine loop to manager")
os.Exit(1)
}
// Create the reconciler
reconciler := &controller.VariantAutoscalingReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Recorder: mgr.GetEventRecorderFor("workload-variant-autoscaler-controller-manager"),
}
// Setup the controller with the manager
if err = reconciler.SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller")
os.Exit(1)
}
// +kubebuilder:scaffold:builder
// Create InferencePool reconciler
inferencePoolReconciler := &controller.InferencePoolReconciler{
Datastore: ds,
Reader: mgr.GetClient(),
PoolGKNN: poolutil.DefaultPoolGKNN(),
}
if err = inferencePoolReconciler.SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create inferencePool controller")
os.Exit(1)
}
if metricsCertWatcher != nil {
setupLog.Info("Adding metrics certificate watcher to manager")
if err := mgr.Add(metricsCertWatcher); err != nil {
setupLog.Error(err, "unable to add metrics certificate watcher to manager")
os.Exit(1)
}
}
if webhookCertWatcher != nil {
setupLog.Info("Adding webhook certificate watcher to manager")
if err := mgr.Add(webhookCertWatcher); err != nil {
setupLog.Error(err, "unable to add webhook certificate watcher to manager")
os.Exit(1)
}
}
if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up health check")
os.Exit(1)
}
if err := mgr.AddReadyzCheck("readyz", healthz.Ping); err != nil {
setupLog.Error(err, "unable to set up ready check")
os.Exit(1)
}
setupLog.Info("Starting manager")
// Sync the custom logger before starting the manager
if err := logging.Sync(); err != nil {
setupLog.Error(err, "Failed to sync logger before starting manager")
os.Exit(1)
}
// Register custom metrics with the controller-runtime Prometheus registry
// This makes the metrics available for scraping by Prometheus and direct endpoint access
setupLog.Info("Registering custom metrics with Prometheus registry")
if err := metrics.InitMetrics(crmetrics.Registry); err != nil {
setupLog.Error(err, "failed to initialize metrics")
os.Exit(1)
}
if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
setupLog.Error(err, "problem running manager")
os.Exit(1)
}
}