Skip to content

Commit a0eab44

Browse files
authored
Merge pull request #16528 from pete-vielhaber/hardstops
docs: examples and restatements syntax to content standardization guidelines
2 parents 77bd515 + b5c057e commit a0eab44

File tree

257 files changed

+468
-452
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

257 files changed

+468
-452
lines changed

.env.example

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# rename this file to .env and supply the values listed below
2-
# also make sure they are available to the build tool (e.g. Netlify)
2+
# also make sure they are available to the build tool (e.g., Netlify)
33
# warning: variables prefixed with NEXT_PUBLIC_ will be made available to client-side code
4-
# be careful not to expose sensitive data (e.g. your Algolia admin key)
4+
# be careful not to expose sensitive data (e.g., your Algolia admin key)
55

66
# Algolia environment (app ID, search key and base search index name required for search)
77
# You can use the following test keys provided by DocSearch for local development/testing:
@@ -35,12 +35,12 @@ NEXT_PUBLIC_MATOMO_SITE_ID=
3535
NEXT_PUBLIC_IS_PREVIEW_DEPLOY=false
3636

3737
# Build pages only for the specified langs. Leave it empty to build all the langs
38-
# e.g. `en,fr` will only build English and French pages
38+
# e.g., `en,fr` will only build English and French pages
3939
# Note: always include `en` as it is the default lang of the site
4040
NEXT_PUBLIC_BUILD_LOCALES=
4141

4242
# If resource constraints are being hit during builds, change LIMIT_CPUS to a
43-
# fixed number of CPUs (e.g. 2) to limit the demand during build time
43+
# fixed number of CPUs (e.g., 2) to limit the demand during build time
4444
LIMIT_CPUS=
4545

4646
# Enables the bundle analyzer

.github/ISSUE_TEMPLATE/suggest_staking_product.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,17 +187,17 @@ body:
187187
id: staking_product_platform_support
188188
attributes:
189189
label: What platforms are supported?
190-
description: ie. Linux, macOS, Windows, iOS, Android, etc
190+
description: i.e., Linux, macOS, Windows, iOS, Android, etc
191191
- type: input
192192
id: staking_product_interface
193193
attributes:
194194
label: What user interfaces are supported?
195-
description: ie. browser app, desktop app, mobile app, CLI app, etc
195+
description: i.e., browser app, desktop app, mobile app, CLI app, etc
196196
- type: textarea
197197
id: staking_product_socials
198198
attributes:
199199
label: Social media links
200-
description: List available social media links. ie. Discord, Twitter, Telegram, Reddit
200+
description: List available social media links. i.e., Discord, Twitter, Telegram, Reddit
201201
- type: checkboxes
202202
id: staking_product_work_on
203203
attributes:

.github/ISSUE_TEMPLATE/suggest_wallet.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ body:
5555
id: wallet_url
5656
attributes:
5757
label: URL to the project
58-
description: Please provide a URL (e.g. to the website of the wallet).
58+
description: Please provide a URL (e.g., to the website of the wallet).
5959
validations:
6060
required: true
6161
- type: input
@@ -129,7 +129,7 @@ body:
129129
id: wallets_hardware
130130
attributes:
131131
label: Is it a hardware wallet?
132-
description: How does it broadcast signed transactions (e.g. USB, Bluetooth, QR code)?
132+
description: How does it broadcast signed transactions (e.g., USB, Bluetooth, QR code)?
133133
validations:
134134
required: true
135135
- type: markdown
@@ -194,7 +194,7 @@ body:
194194
id: wallet_scam_protection
195195
attributes:
196196
label: Scam protection?
197-
description: Does the wallet employ any practices to warn users against potential scams (e.g. when interacting with suspicious accounts/contracts)?
197+
description: Does the wallet employ any practices to warn users against potential scams (e.g., when interacting with suspicious accounts/contracts)?
198198
validations:
199199
required: true
200200
- type: markdown
@@ -205,7 +205,7 @@ body:
205205
id: wallet_dapp_support
206206
attributes:
207207
label: Does the wallet support connecting to Ethereum applications?
208-
description: Please provide documentation for how users connect to applications. List examples (ie. WalletConnect, connect wallet to dapp directly, in wallet browser, etc.)
208+
description: Please provide documentation for how users connect to applications. List examples (i.e., WalletConnect, connect wallet to dapp directly, in wallet browser, etc.)
209209
validations:
210210
required: true
211211
- type: dropdown
@@ -379,7 +379,7 @@ body:
379379
id: wallet_extra
380380
attributes:
381381
label: Does the wallet have any integrated tools not mentioned above?
382-
description: Please provide any information about extra features this wallet has that we may have missed in the above criteria. (e.g. privacy features, transaction batching, etc).
382+
description: Please provide any information about extra features this wallet has that we may have missed in the above criteria. (e.g., privacy features, transaction batching, etc).
383383
- type: checkboxes
384384
id: wallet_work_on
385385
attributes:

CODE_OF_CONDUCT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Examples of unacceptable behavior by participants include:
6262

6363
Violations of the code of conduct will normally be visible to the community as we try to do everything in open, public channels, allowing community members to self-police.
6464

65-
However, if something happens that you feel needs attention, you can raise it with someone who has a moderation role (e.g. discord guide) so that they can help investigate and execute the appropriate response.
65+
However, if something happens that you feel needs attention, you can raise it with someone who has a moderation role (e.g., discord guide) so that they can help investigate and execute the appropriate response.
6666

6767
When reporting, please include as much detail as possible, including specific examples and timestamps. This will help to ensure a fair outcome.
6868

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ pnpm dev
135135
- Open this directory in your favorite text editor / IDE, and see your changes live by visiting `localhost:3000` from your browser
136136
- Pro Tip:
137137
- Explore scripts within `package.json` for more build options
138-
- Get **faster** production builds by building only one language. E.g. in your `.env` file, set `NEXT_PUBLIC_BUILD_LOCALES=en` to build the content only in English
138+
- Get **faster** production builds by building only one language, e.g., in your `.env` file, set `NEXT_PUBLIC_BUILD_LOCALES=en` to build the content only in English
139139
- To build the site in other selected languages too, you need to set them in `NEXT_PUBLIC_BUILD_LOCALES`, eg: `NEXT_PUBLIC_BUILD_LOCALES=en,es` if you also want to build only English (required) and Spanish.
140140
- To build all languages, simply comment this line out with a hash mark, eg: `# NEXT_PUBLIC_BUILD_LOCALES=`
141141

@@ -158,7 +158,7 @@ git push
158158
- After your changes are committed to your GitHub fork, submit a pull request (PR) to the `dev` branch of the `ethereum/ethereum-org-website` repo
159159
- In your PR description, reference the issue it resolves (see [linking a pull request to an issue using a keyword](https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
160160
- ex. `Updates out of date content [Fixes #1234]`
161-
- Netlify (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.: ![Netlify deploy preview](public/images/preview-deploy.png)
161+
- Netlify (our hosting service for build previews) deploys all PRs to a publicly accessible preview URL, e.g.,: ![Netlify deploy preview](public/images/preview-deploy.png)
162162
- _Confirm that your Netlify preview deploy looks and functions as expected_
163163
- Why not say hi and draw attention to your PR in [our discord server](https://discord.gg/ethereum-org)?
164164

docs/applying-storybook.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ type Story = StoryObj<typeof meta>;
5252
export const Basic: Story = {}
5353
```
5454

55-
- With the `title` option, we write this based on the groupings set by the Design System. Groupings are declared with forward slashes. (i.e. `Atoms / Form / Input`). See the Storybook docs for details on [Naming conventions](https://storybook.js.org/docs/7.0/react/writing-stories/naming-components-and-hierarchy)
55+
- With the `title` option, we write this based on the groupings set by the Design System. Groupings are declared with forward slashes. (i.e., `Atoms / Form / Input`). See the Storybook docs for details on [Naming conventions](https://storybook.js.org/docs/7.0/react/writing-stories/naming-components-and-hierarchy)
5656
- The `satisfies` TypeScript keyword is used with the `Meta` type for stricter type checking. This is particularly helpful to make sure required args are not missed. [Storybook Docs regarding `satisfies`](https://storybook.js.org/docs/writing-stories/typescript#using-satisfies-for-better-type-safety)
5757
- The use of `StoryObj` is to be able to typecheck the creation of a story as an object. This helps with prop inference.
5858
- We use `StoryObj<typeof meta>` in the event a required arg is provided in the `meta` object, to be applied to all stories in the file. This prevents type errors throwing at the story level for a required missing arg.
59-
- If the story does not need any args or any custom rendering, it should be left as an empty object. Otherwise, use the `render` option to explicitly write the rendering of the story: i.e. `render: () => <Component />`
59+
- If the story does not need any args or any custom rendering, it should be left as an empty object. Otherwise, use the `render` option to explicitly write the rendering of the story: i.e., `render: () => <Component />`
6060

6161
Also, please view the Figma file for the [proposed structure for the Design System](https://www.figma.com/file/Ne3iAassyfAcJ0AlgqioAP/DS-to-storybook-structure?type=design&node-id=42%3A50&mode=design&t=RGkyouvTilzF42y0-1) to provide the correct groupings.
6262

docs/best-practices.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ How to prepare your content for translation depends on whether you're working on
88

99
**- MDX pages (`public/content/page/`)**
1010

11-
Markdown will be translated as whole pages of content, so no specific action is required. Simply create a new folder within `public/content/` with the name of the page, then place an index markdown file (ie. `index.md`) within the new folder.
11+
Markdown will be translated as whole pages of content, so no specific action is required. Simply create a new folder within `public/content/` with the name of the page, then place an index markdown file (i.e., `index.md`) within the new folder.
1212

1313
**- React component page**
1414

docs/code-conventions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ For the props type signature use the naming convention `<ComponentName>Props` to
6565

6666
A positive side-effect to directly annotating the props object is for IDE intellisense where you can view the props when hovering over the component name to see it's signature.
6767

68-
i.e. `const Component: ({ label, title, ...props }: ComponentProps) => React.JSX.Element`
68+
i.e., `const Component: ({ label, title, ...props }: ComponentProps) => React.JSX.Element`
6969

7070
#### Use the type alias for props type
7171

docs/ds-implementation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ If you are implementing:
3838

3939
### 🧩 Base components
4040

41-
*(components that already exist in the [shadcn/ui components list](https://ui.shadcn.com/docs/components), e.g. Button, Input, Alert)*
41+
*(components that already exist in the [shadcn/ui components list](https://ui.shadcn.com/docs/components), e.g., Button, Input, Alert)*
4242

4343
* Do **not** create a new component file under `/ComponentA/index.tsx` unless additional or custom logic is required.
4444
* Extend or style base components in `src/components/ui`.
@@ -47,7 +47,7 @@ If you are implementing:
4747

4848
### 🧱 Custom components
4949

50-
*(components not covered by shadcn/ui, e.g. PageHero)*
50+
*(components not covered by shadcn/ui, e.g., PageHero)*
5151

5252
* Use base `ui` components whenever possible.
5353
* Keep the structure consistent with the DS and Figma specifications.

docs/event-tracking.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ It's helpful to ask yourself how the results of what we track and measure might
3535

3636
# How to name events?
3737

38-
Broadly, events should be grouped by specific topic (e.g. L2 page external links, selected bridge, selected cex).
38+
Broadly, events should be grouped by specific topic (e.g., L2 page external links, selected bridge, selected cex).
3939

4040
## Each event comprises 4 hierarchical values:
4141

0 commit comments

Comments
 (0)