Skip to content

Conversation

@horw
Copy link
Collaborator

@horw horw commented Dec 23, 2024

Description

This PR introduces a skip_if_soc marker that helps filter targets based on their SOC_CAPS.h attributes.

Related

Closes #326

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@horw horw force-pushed the feat/skip_if_soc_marker branch 3 times, most recently from 4a19463 to f5e1dd5 Compare December 24, 2024 04:01
@horw horw force-pushed the feat/skip_if_soc_marker branch 2 times, most recently from ea88eea to 088b2ca Compare January 7, 2025 03:07
@horw horw requested a review from hfudev January 7, 2025 03:08
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@horw horw force-pushed the feat/skip_if_soc_marker branch from 088b2ca to 614f347 Compare January 9, 2025 08:22
@horw horw requested a review from hfudev January 9, 2025 08:22
@horw horw force-pushed the feat/skip_if_soc_marker branch from 614f347 to a442a7d Compare January 9, 2025 08:25
@horw
Copy link
Collaborator Author

horw commented Jan 9, 2025

Let's mock esp_bool_parser's SUPPORTED_TARGET, and SOC_CAPS, because we don't dependent on ESP-IDF repo itself; let's just mock them.

@hfudev
Copy link
Member

hfudev commented Jan 10, 2025

Let's mock esp_bool_parser's SUPPORTED_TARGET, and SOC_CAPS, because we don't dependent on ESP-IDF repo itself; let's just mock them.

sure. we could create a temp IDF_PATH folder, and create IDF_PATH/tools/cmake/version.cmake and IDF_PATH/components/soc/<target>/include/soc/soc_caps.h to mock it.

@horw horw force-pushed the feat/skip_if_soc_marker branch from 864cd07 to f1878de Compare January 14, 2025 08:15
@horw horw requested a review from hfudev January 14, 2025 08:21
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please also add a documentation page under usages/markers.rst

@horw horw force-pushed the feat/skip_if_soc_marker branch from f1878de to 1f785e8 Compare January 14, 2025 13:37
@horw horw force-pushed the feat/skip_if_soc_marker branch from 1f785e8 to 5a5bce0 Compare January 14, 2025 15:31
@horw horw requested a review from hfudev January 15, 2025 09:27
@horw horw force-pushed the feat/skip_if_soc_marker branch from 5208a89 to 5f6e5f6 Compare January 15, 2025 11:02
@hfudev hfudev merged commit 48bb1b4 into espressif:main Jan 16, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[idf] Support Skip Marker for ESP-IDF Soc Caps (RDT-1055)

3 participants