-
Notifications
You must be signed in to change notification settings - Fork 9
fix: add disabled apps to junit with --include-all-apps flag
#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the --include-all-apps flag in the build command to properly include disabled apps in JUnit reports with their correct disable reasons from the Manifest file instead of a generic message.
Key changes:
- Modified main.py to create separate
FindArgumentsobject when running build command to properly handle--include-all-appsflag - Removed generic "Build {status}. Skipping..." message that was overwriting the meaningful disable reasons set by manifest rules
- Added console output to display disabled apps after build completion
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| idf_build_apps/main.py | Creates separate FindArguments for build command to handle include_all_apps flag, adds disabled apps console output |
| idf_build_apps/app.py | Removes line that overwrote manifest-provided disable reasons with generic message |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Because build needs to find apps, we need to create find_arguments here | ||
| find_arguments = FindArguments( | ||
| **{k: v for k, v in kwargs_without_none.items() if k in FindBuildArguments.model_fields} | ||
| ) |
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new logic for creating FindArguments from BuildArguments kwargs lacks test coverage. This is a critical code path that ensures --include-all-apps works correctly with the build command by filtering kwargs to only those in FindBuildArguments.model_fields. Tests should verify that flags like --include-all-apps properly propagate from BuildArguments to FindArguments.
cbf08d4 to
e5f1fca
Compare
26d3efd to
9c473cd
Compare
9c473cd to
eeebc61
Compare
This MR fixes
--include-all-appsflag inbuildcommand.Now it's possible to include all apps to Junit report with:
Disabled apps are also shown in the output, with the correct reason taken from Manifest file.
Related
#102