Skip to content

Conversation

@robert-alfaro
Copy link

@robert-alfaro robert-alfaro commented Oct 31, 2025

Description

Similar to iot_button_get_event(), iot_button_get_hardware_data() method allows for easily retrieving hardware related data from the button object such as gpio pin number or adc channel.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello robert-alfaro, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ab86559

@robert-alfaro robert-alfaro force-pushed the feature/get-btn-hw-data branch from 63dac97 to ab86559 Compare October 31, 2025 16:33
@github-actions github-actions bot changed the title button: add get_hardware_data() to iot_button button: add get_hardware_data() to iot_button (AEGHB-1291) Oct 31, 2025
@robert-alfaro robert-alfaro changed the title button: add get_hardware_data() to iot_button (AEGHB-1291) feat(button): add iot_button_get_hardware_data() method (AEGHB-1291) Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants