return in finally can swallow exception (IDFGH-13928)

[iritkatriel]

Checklist

• Checked the issue tracker for similar issues to ensure this is not a duplicate
• Read the documentation to confirm the issue is not addressed there and your configuration is set correctly
• Tested with the latest version to ensure the issue hasn't been fixed

How often does this bug occurs?

always

Expected behavior

Avoid return in finally.

Actual behavior (suspected bug)

In

esp-idf-kconfig/kconfcheck/core.py

Line 540 in 109e663

return True

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if a BaseException (such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

Error logs or terminal output

No response

Steps to reproduce the behavior

See

esp-idf-kconfig/kconfcheck/core.py

Line 540 in 109e663

return True

Project release version

main branch

System architecture

other (details in Additional context)

Operating system

Linux

Operating system version

NA

Shell

ZSH

Additional context

No response

[iritkatriel]

Note also return in finally in

esp-idf-kconfig/menuconfig/core.py

Line 779 in 109e663

return curses.endwin()

[Honza0297]

Hello @iritkatriel and thank you for finding this!

We will discuss this in internal code review and post the results here.