Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does Espanso require cargo-make version 0.34.0 specifically? #87

Open
Oneechan69 opened this issue Feb 28, 2025 · 3 comments
Open

Does Espanso require cargo-make version 0.34.0 specifically? #87

Oneechan69 opened this issue Feb 28, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@Oneechan69
Copy link

Oneechan69 commented Feb 28, 2025

The documentation for compiling has a step to run cargo install --force cargo-make --version 0.34.0.

It fits better in the issues section than the Discord server, if its not necessary then shouldn't the documentation be changed to just install the latest version? If so then should there be a reason listed?

@Oneechan69 Oneechan69 added the bug Something isn't working label Feb 28, 2025
@smeech
Copy link
Collaborator

smeech commented Feb 28, 2025

I don't believe so. IIRC, I didn't include the --version 0.34.0 last time I compiled.
I'm awaiting confirmation from others (so it may be worth airing again on Discord) before I change the https://github.com/espanso/website (which is perhaps a better place for this thread, so I'll transfer it).

@smeech smeech mentioned this issue Feb 28, 2025
31 tasks
@smeech smeech transferred this issue from espanso/espanso Feb 28, 2025
@MRDGH2821
Copy link

I once used 0.37.0 to compile from the dev/main branch back in Nov 2024.
It didn't work.

There may be many more commits now, so can't say anything on the current state of things.

To compile espanso v2.2.1, cargo-make v0.34.0 was absolutely needed, otherwise compilation errors would popup & ultimately fail.

@AucaCoyan
Copy link
Member

Since 0.37.24 was released (the current latest version), I've seen this error in all OSes when I try to compile espanso:

/home/acoyan/.cargo/bin/cargo-make: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.39' not found (required by /home/acoyan/.cargo/bin/cargo-make)
/home/acoyan/.cargo/bin/cargo-make: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.38' not found (required by /home/acoyan/.cargo/bin/cargo-make)

I have no idea why. Tried with the development version of cargo make but didn't went very far.
The changelog is here but I don't see any big changes. Could be the LTO? 🤔

Anyway. Federico used to compile with a locked version of cargo make, and a few months ago I released that lock to use the latest version. 2 cheetos later it doesn't work.

What can we do about this?

  • one way is locking again to 0.37.23, which works and edit the documentation (my preference)
  • and the other is keep trying to use the latest, submit the issue to cargo-make and hope it gets resolved soon. It's not bad, but we need to respond to the users who will ask in discord why the install instructions doesn't give the expected results.

Can you think in a different solution? do you prefer one of those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants