Skip to content

Commit 9c5c8cc

Browse files
committed
apply suggested changes from code review
1 parent 97de75f commit 9c5c8cc

File tree

2 files changed

+35
-34
lines changed

2 files changed

+35
-34
lines changed

docs/rules/fenced-code-meta.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ console.log("Hello, world!");
2424

2525
This rule accepts a single string option:
2626

27-
- "always" (default): Require metadata when a language is specified.
28-
- "never": Disallow metadata in the info string.
27+
- `"always"` (default): Require metadata when a language is specified.
28+
- `"never"`: Disallow metadata in the info string.
2929

3030
Examples of **incorrect** code when configured as `"fenced-code-meta": ["error", "always"]`:
3131

@@ -49,23 +49,23 @@ console.log("Hello, world!");
4949

5050
Examples of **incorrect** code when configured as `"fenced-code-meta": ["error", "never"]`:
5151

52-
```markdown
52+
````markdown
5353
<!-- eslint markdown/fenced-code-meta: ["error", "never"] -->
5454

55-
~~~js title="example.js"
55+
```js title="example.js"
5656
console.log("Hello, world!");
57-
~~~
5857
```
58+
````
5959

6060
Examples of **correct** code when configured as `"fenced-code-meta": ["error", "never"]`:
6161

62-
```markdown
62+
````markdown
6363
<!-- eslint markdown/fenced-code-meta: ["error", "never"] -->
6464

65-
~~~js
65+
```js
6666
console.log("Hello, world!");
67-
~~~
6867
```
68+
````
6969

7070
## When Not to Use It
7171

tests/rules/fenced-code-meta.test.js

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import rule from "../../src/rules/fenced-code-meta.js";
1111
import markdown from "../../src/index.js";
1212
import { RuleTester } from "eslint";
13+
import dedent from "dedent";
1314

1415
//------------------------------------------------------------------------------
1516
// Tests
@@ -24,56 +25,56 @@ const ruleTester = new RuleTester({
2425

2526
ruleTester.run("fenced-code-meta", rule, {
2627
valid: [
27-
`\`\`\`
28+
dedent`\`\`\`
2829
console.log("Hello, world!");
2930
\`\`\``,
30-
`\`\`\`js foo
31+
dedent`\`\`\`js foo
3132
console.log("Hello, world!");
3233
\`\`\``,
33-
`\`\`\` js foo
34+
dedent`\`\`\` js foo
3435
console.log("Hello, world!");
3536
\`\`\``,
3637
{
37-
code: `\`\`\`
38+
code: dedent`\`\`\`
3839
console.log("Hello, world!");
3940
\`\`\``,
4041
options: ["never"],
4142
},
4243
{
43-
code: `\`\`\`js
44+
code: dedent`\`\`\`js
4445
console.log("Hello, world!");
4546
\`\`\``,
4647
options: ["never"],
4748
},
4849
{
49-
code: `\`\`\` js
50+
code: dedent`\`\`\` js
5051
console.log("Hello, world!");
5152
\`\`\``,
5253
options: ["never"],
5354
},
54-
`~~~
55+
dedent`~~~
5556
console.log("Hello, world!");
5657
~~~`,
57-
`~~~js foo
58+
dedent`~~~js foo
5859
console.log("Hello, world!");
5960
~~~`,
60-
`~~~ js foo
61+
dedent`~~~ js foo
6162
console.log("Hello, world!");
6263
~~~`,
6364
{
64-
code: `~~~
65+
code: dedent`~~~
6566
console.log("Hello, world!");
6667
~~~`,
6768
options: ["never"],
6869
},
6970
{
70-
code: `~~~js
71+
code: dedent`~~~js
7172
console.log("Hello, world!");
7273
~~~`,
7374
options: ["never"],
7475
},
7576
{
76-
code: `~~~ js
77+
code: dedent`~~~ js
7778
console.log("Hello, world!");
7879
~~~`,
7980
options: ["never"],
@@ -86,7 +87,7 @@ ruleTester.run("fenced-code-meta", rule, {
8687
],
8788
invalid: [
8889
{
89-
code: `\`\`\`javascript
90+
code: dedent`\`\`\`javascript
9091
console.log("Hello, world!");
9192
\`\`\``,
9293
errors: [
@@ -100,7 +101,7 @@ ruleTester.run("fenced-code-meta", rule, {
100101
],
101102
},
102103
{
103-
code: `~~~javascript
104+
code: dedent`~~~javascript
104105
console.log("Hello, world!");
105106
~~~`,
106107
errors: [
@@ -114,7 +115,7 @@ ruleTester.run("fenced-code-meta", rule, {
114115
],
115116
},
116117
{
117-
code: `\`\`\` js
118+
code: dedent`\`\`\` js
118119
console.log("Hello, world!");
119120
\`\`\``,
120121
errors: [
@@ -128,7 +129,7 @@ ruleTester.run("fenced-code-meta", rule, {
128129
],
129130
},
130131
{
131-
code: `~~~ js
132+
code: dedent`~~~ js
132133
console.log("Hello, world!");
133134
~~~`,
134135
errors: [
@@ -142,7 +143,7 @@ ruleTester.run("fenced-code-meta", rule, {
142143
],
143144
},
144145
{
145-
code: `\`\`\`js title="example.js"
146+
code: dedent`\`\`\`js title="example.js"
146147
console.log("Hello, world!");
147148
\`\`\``,
148149
options: ["never"],
@@ -157,7 +158,7 @@ ruleTester.run("fenced-code-meta", rule, {
157158
],
158159
},
159160
{
160-
code: `~~~js title="example.js"
161+
code: dedent`~~~js title="example.js"
161162
console.log("Hello, world!");
162163
~~~`,
163164
options: ["never"],
@@ -172,7 +173,7 @@ ruleTester.run("fenced-code-meta", rule, {
172173
],
173174
},
174175
{
175-
code: `\`\`\`js foo bar
176+
code: dedent`\`\`\`js foo bar
176177
console.log("Hello, world!");
177178
\`\`\``,
178179
options: ["never"],
@@ -187,7 +188,7 @@ ruleTester.run("fenced-code-meta", rule, {
187188
],
188189
},
189190
{
190-
code: `~~~js foo bar
191+
code: dedent`~~~js foo bar
191192
console.log("Hello, world!");
192193
~~~`,
193194
options: ["never"],
@@ -202,7 +203,7 @@ ruleTester.run("fenced-code-meta", rule, {
202203
],
203204
},
204205
{
205-
code: `\`\`\` js foo
206+
code: dedent`\`\`\` js foo
206207
console.log("Hello, world!");
207208
\`\`\``,
208209
options: ["never"],
@@ -217,7 +218,7 @@ ruleTester.run("fenced-code-meta", rule, {
217218
],
218219
},
219220
{
220-
code: `~~~ js foo
221+
code: dedent`~~~ js foo
221222
console.log("Hello, world!");
222223
~~~`,
223224
options: ["never"],
@@ -232,7 +233,7 @@ ruleTester.run("fenced-code-meta", rule, {
232233
],
233234
},
234235
{
235-
code: `\`\`\`js js
236+
code: dedent`\`\`\`js js
236237
console.log("Hello, world!");
237238
\`\`\``,
238239
options: ["never"],
@@ -247,7 +248,7 @@ ruleTester.run("fenced-code-meta", rule, {
247248
],
248249
},
249250
{
250-
code: `~~~js js
251+
code: dedent`~~~js js
251252
console.log("Hello, world!");
252253
~~~`,
253254
options: ["never"],
@@ -262,7 +263,7 @@ ruleTester.run("fenced-code-meta", rule, {
262263
],
263264
},
264265
{
265-
code: `\`\`\` js foo
266+
code: dedent`\`\`\` js foo
266267
console.log("Hello, world!");
267268
\`\`\``,
268269
options: ["never"],
@@ -277,7 +278,7 @@ ruleTester.run("fenced-code-meta", rule, {
277278
],
278279
},
279280
{
280-
code: `~~~ js foo
281+
code: dedent`~~~ js foo
281282
console.log("Hello, world!");
282283
~~~`,
283284
options: ["never"],

0 commit comments

Comments
 (0)