Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: error in images fetched from github #679

Open
1 task done
Tanujkanti4441 opened this issue Dec 20, 2024 · 5 comments · May be fixed by #680 or #683
Open
1 task done

Bug: error in images fetched from github #679

Tanujkanti4441 opened this issue Dec 20, 2024 · 5 comments · May be fixed by #680 or #683
Assignees
Labels
accepted bug Something isn't working repro:needed This issue should include a reproducible example

Comments

@Tanujkanti4441
Copy link
Contributor

Tanujkanti4441 commented Dec 20, 2024

URL(s)

https://eslint.org/team/
https://eslint.org/sponsors/
other

What did you do?

went to the website.

What did you expect to happen?

there must be the images of sponsors, authors and team members.

What actually happened?

most of the images were not there.
Image
Image
Image

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

All the images with issue are sourced from github and were updated in
45a54f8

@Tanujkanti4441 Tanujkanti4441 added bug Something isn't working repro:needed This issue should include a reproducible example labels Dec 20, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Dec 20, 2024
@Tanujkanti4441 Tanujkanti4441 changed the title Bug: some images are not shown Bug: error in images fetched from github Dec 20, 2024
@amareshsm amareshsm moved this from Needs Triage to Ready to Implement in Triage Dec 20, 2024
@amareshsm
Copy link
Member

Do you know why the images, which were visible earlier, are not visible now?

@Tanujkanti4441
Copy link
Contributor Author

Do you know why the images, which were visible earlier, are not visible now?

Still figuring out! seems github action bot has updated the image links in data.

@Tanujkanti4441
Copy link
Contributor Author

Tanujkanti4441 commented Dec 20, 2024

So github is now issuing JWT-signed avatars living on the private-avatars.githubusercontent.com subdomains, and these new tokens are generated each 15 minutes. They are valid for 20 minutes after their generation. This makes them usable between 5-20 minutes depending on the retrieval time after their generation.

It is asked here also https://github.com/orgs/community/discussions/147297

that's why github action bot is updating the link's token daily i guess, as a solution we can omit the private- word from the avatar link, would like to here some opinions on this approach.

@mdjermanovic
Copy link
Member

It is asked here also https://github.com/orgs/community/discussions/147297

that's why github action bot is updating the link's token daily i guess, as a solution we can omit the private- word from the avatar link, would like to here some opinions on this approach.

I'm not sure I understand everything in the linked discussion, but let's try to re-construct the old URLs from the new ones, at least as a temporary solution.

@amareshsm
Copy link
Member

amareshsm commented Dec 20, 2024

Based on the discussion in this thread, as long as the user is not an Enterprise Managed User (EMU), the old URL will continue to work as expected. Therefore, as a solution, we can proceed with constructing the old URL.

@Tanujkanti4441 Tanujkanti4441 linked a pull request Dec 21, 2024 that will close this issue
1 task
nzakas added a commit that referenced this issue Dec 30, 2024
@nzakas nzakas linked a pull request Dec 30, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working repro:needed This issue should include a reproducible example
Projects
Status: Ready to Implement
3 participants