Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add code explorer in the navbar #682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Add code explorer in the navbar

What changes did you make? (Give an overview)

Fixes #676

Related Issues

Is there anything you'd like reviewers to focus on?

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/676ef95bd6d4bc00082633d6
😎 Deploy Preview https://deploy-preview-682--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/676ef95bca061e0008a1fc09
😎 Deploy Preview https://deploy-preview-682--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/676ef95bf5b3ac0008c0b9b1
😎 Deploy Preview https://deploy-preview-682--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/676ef95b9148760008258a06
😎 Deploy Preview https://deploy-preview-682--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/676ef95b2c5c3e000858d7cc
😎 Deploy Preview https://deploy-preview-682--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/676ef95bc9d70a0008f64f26
😎 Deploy Preview https://deploy-preview-682--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/676ef95b3199830008ab4eef
😎 Deploy Preview https://deploy-preview-682--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 896add9
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/676ef95b1ca1b00008aa0430
😎 Deploy Preview https://deploy-preview-682--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Tanujkanti4441 Tanujkanti4441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of the language versions, navbar is collapsing the ESLint logo:
In spanish
Screenshot 2024-12-28 132509
In japanese
Screenshot 2024-12-28 132927
In French
Screenshot 2024-12-28 133106

and in Portuguese, and German also

should we make the dropdown navbar appear in 1023px as in docs?

@amareshsm
Copy link
Member Author

In most of the language versions, navbar is collapsing the ESLint logo: In spanish Screenshot 2024-12-28 132509 In japanese Screenshot 2024-12-28 132927 In French Screenshot 2024-12-28 133106

and in Portuguese, and German also

should we make the dropdown navbar appear in 1023px as in docs?

yes, I will change it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

Suggestion: Add code explorer link to the nav bar
2 participants