chore: minor cleanup

Author: RebeccaStevens

.editorconfig

@@ -7,6 +7,3 @@ indent_size = 2
 charset = utf-8
 trim_trailing_whitespace = true
 insert_final_newline = true
-
-[*.md]
-trim_trailing_whitespace = false

.eslintrc.json

@@ -30,7 +30,7 @@
     ],
     "sourceType": "module"
   },
-  "ignorePatterns": ["build/", "coverage/", "lib/", "**/*.js"],
+  "ignorePatterns": ["/build/", "/coverage/", "/lib/", "/**/*.cjs", "/**/*.js"],
   "rules": {
     "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-unnecessary-condition": "off",

.gitignore

@@ -1,9 +1,11 @@
-.DS_Store
-thumbs.db
-*.log
-.nyc_output/
-node_modules/
-/build/
 /lib/
+/build/
 /coverage/
-js_out/
+
+.nyc_output/
+node_modules/
+
+*.log
+
+.DS_Store
+thumbs.db

.lintstagedrc

@@ -1,8 +1,5 @@
 {
-  "./**/*.{json,yml}": [
-    "prettier --write"
-  ],
-  "./**/*.md": [
+  "./**/*.{md,json,jsonc,yml}": [
     "prettier --write"
   ],
   "./**/*.ts": [

.prettierignore

@@ -1 +1,3 @@
-CHANGELOG.md
+/CHANGELOG.md
+/lib/
+/build/

.vscode/settings.json

@@ -3,27 +3,35 @@
     ".nyc_output": true,
     "coverage": true,
     "cz-adapter/index.js": true,
+    "ava.config.cjs": true,
+    "rollup.config.cjs": true
   },
   "files.trimTrailingWhitespace": true,
   "search.exclude": {
     "**/.git/": true,
     "**/.nyc_output/": true,
-    "**/yarn.lock": true,
     ".vscode/": true,
     "build/": true,
     "lib/": true,
+    "ava.config.cjs": true,
+    "rollup.config.cjs": true,
+    "yarn.lock": true
   },
   "typescript.tsdk": "./node_modules/typescript/lib",
+  "files.associations": {
+    ".markdownlint.json": "jsonc",
+    ".markdownlintignore": "ignore"
+  },
   "[json]": {
     "editor.defaultFormatter": "vscode.json-language-features",
-    "editor.formatOnSave": false,
+    "editor.formatOnSave": true
   },
   "[jsonc]": {
     "editor.defaultFormatter": "vscode.json-language-features",
-    "editor.formatOnSave": false,
+    "editor.formatOnSave": true
   },
   "[typescript]": {
     "editor.defaultFormatter": "esbenp.prettier-vscode",
-    "editor.formatOnSave": true,
-  },
+    "editor.formatOnSave": true
+  }
 }

ava.config.cjs

@@ -0,0 +1,7 @@
+require("ts-node").register({
+  compilerOptions: {
+    module: "CommonJS",
+  },
+});
+
+module.exports = require("./ava.config.ts").default;

ava.config.js renamed to ava.config.ts

@@ -1,9 +1,7 @@
-// @ts-check
-
 /**
  * Get the intended boolean value from the given string.
  */
-function getBoolean(value) {
+function getBoolean(value: unknown) {
   if (value === undefined) {
     return false;
   }

cz-adapter/options.ts

@@ -49,11 +49,11 @@ const types = {
 };
 
 const defaults: {
-  readonly defaultType?: string;
-  readonly defaultScope?: string;
-  readonly defaultSubject?: string;
-  readonly defaultBody?: string;
-  readonly defaultIssues?: string;
+  readonly defaultType: string | undefined;
+  readonly defaultScope: string | undefined;
+  readonly defaultSubject: string | undefined;
+  readonly defaultBody: string | undefined;
+  readonly defaultIssues: string | undefined;
 } = {
   defaultType: process.env.CZ_TYPE,
   defaultScope: process.env.CZ_SCOPE,

rollup.config.cjs

@@ -0,0 +1,7 @@
+require("ts-node").register({
+  compilerOptions: {
+    module: "CommonJS",
+  },
+});
+
+module.exports = require("./rollup.config.ts");

rollup.config.js renamed to rollup.config.ts

@@ -1,7 +1,6 @@
 /**
  * Rollup Config.
  */
-// @ts-check
 
 import rollupPluginCommonjs from "@rollup/plugin-commonjs";
 import rollupPluginJSON from "@rollup/plugin-json";

src/rules/prefer-tacit.ts

@@ -160,7 +160,7 @@ function getCallDescriptors(
             // Unless user specifies they want it.
             (typeof options.assumeTypes === "object" &&
               !options.assumeTypes.allowFixer)
-              ? undefined
+              ? null
               : (fixer) => fixer.replaceText(node, calleeName),
         },
       ];

tests/tsconfig.json

@@ -6,6 +6,7 @@
     "skipLibCheck": true,
     "declaration": false,
     // Turn off strict checks to make debugging nicer.
-    "strict": false
+    "strict": false,
+    "exactOptionalPropertyTypes": false
   }
 }

tsconfig.base.json

@@ -1,12 +1,26 @@
 {
   "compilerOptions": {
     "allowSyntheticDefaultImports": true,
+    "allowUnreachableCode": false,
+    "allowUnusedLabels": false,
     "esModuleInterop": true,
+    "exactOptionalPropertyTypes": true,
     "forceConsistentCasingInFileNames": true,
     "importHelpers": false,
-    "lib": [
-      "ESNext"
-    ],
+    "lib": ["ESNext"],
+    "module": "ESNext",
+    "moduleResolution": "node",
+    "newLine": "LF",
+    "noEmitOnError": true,
+    "noImplicitReturns": true,
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
+    "pretty": true,
+    "resolveJsonModule": true,
+    "sourceMap": false,
+    "strict": true,
+    "alwaysStrict": true,
+    "target": "ES2018",
     "baseUrl": ".",
     "paths": {
       "~/*": ["./*"],
@@ -18,13 +32,6 @@
       "~/util/*": ["src/util/*"],
       "~/conditional-imports/*": ["src/util/conditional-imports/*"],
       "~/tests/*": ["tests/*"]
-    },
-    "module": "ESNext",
-    "moduleResolution": "node",
-    "newLine": "LF",
-    "noEmitOnError": true,
-    "resolveJsonModule": true,
-    "strict": true,
-    "target": "ES2018"
+    }
   }
 }