Is it possible to add a return_constraint to GBFS feeds?

[1Maxnet1]

Hey,
I am currently investigating an issue of integrating the GBFS feed of RegioRad Stuttgart to transitous.org. One issue the routing has, is that it does not handle the missing return_constraint of the currently used feed well. The most elegant solution imho. would be to add the return_constraint for vehicle_type.json to the feed. For RegioRad Stuttgart I can confirm that it is any_station for both vehicle_types. Is it possible to add this constraint to the GBFS API easily? If so I would love to switch to the GBFS feed of CityBike, as the republished GBFS feed by Mobidata-BW we are currently using, also lacks the attribute.

[eskerda]

TIL return_constraint. Let me look into this and see a way to include it without leaking too much in our data model

[eskerda]

The original feed from deutschebahn does not include it either

(Pdb) from pprint import pprint
(Pdb) pprint(vehicle_info)
{'data': {'vehicle_types': [{'form_factor': 'bicycle',
                             'name': 'bike',
                             'propulsion_type': 'human',
                             'vehicle_type_id': '5e7fd67c-d83b-3273-84b1-a1597eb84eb7'},
                            {'form_factor': 'bicycle',
                             'max_range_meters': 60000.0,
                             'name': 'pedelec',
                             'propulsion_type': 'electric_assist',
                             'vehicle_type_id': '6058fa31-2370-3e4d-bf5c-34399fd25a09'}]},
 'last_updated': 1746124682,
 'ttl': 210,
 'version': '2.3'}

I think we can try to find a way to hardcode it for this feed (or any feed where someone knows for certain what return constraint should be). Once it lands in pybikes it's just a matter of exposing it on https://github.com/citybikes/gbfs-api

My first guess on the best place to hardcode this info is on the instance file itself as a class init argument:

pybikes/pybikes/data/deutschebahn.json

Lines 82 to 92 in 14c0d0f

	{
	"tag": "stadtrad-stuttgart",
	"provider": "RegioRadStuttgart",
	"meta": {
	"name": "RegioRadStuttgart",
	"city": "Stuttgart",
	"latitude": 48.778147,
	"longitude": 9.1801512,
	"country": "DE"
	}
	}

[eskerda]

For RegioRad Stuttgart I can confirm that it is any_station for both vehicle_types.

@1Maxnet1 checking the GBFS docs on any_station it seems to imply that vehicles can only be returned at stations. But seeing the feed there are at least some vehicles out of stations

Are you 100% that it's any_station and not hybrid?

Also, do you know if that's the case for all deutschebahn systems?

[1Maxnet1]

Are you 100% that it's any_station and not hybrid?

For meinRad I don't know (yet). My question was regarding RegioRadStuttgart. And for RegioRadStuttgart I can confirm that you can only return bikes at stations. I am not sure, whether this can be generalized to all DeutscheBahn systems, so for now, I would only set it for RegioRadStuttgart and further investigate before setting it for other systems.

[eskerda]

My bad, I got both feeds mixed up. Same thing happens for RegioRadStuttgart though

See https://citybik.es/map/stadtrad-stuttgart (blue dots)

[1Maxnet1]

My bad, I got both feeds mixed up. Same thing happens for RegioRadStuttgart though

See https://citybik.es/map/stadtrad-stuttgart (blue dots)

Really interesting catch. As I said you are obligated to put it back at a station: https://www.regioradstuttgart.de/de/sofunktionierts (German site, but if you translate with the Browser integrated translation it should confirm you what I said)
The particular place, you just sends me happens to be a workshop where they fix broken bikes, maybe they are not properly marked as currently-not-in-rentable in the system? But there are othe rplaces where bikes show up near stations but not as at stations in the app. I will report this issue and report back. Anyway as the link suggests, you are meant to return them at stations.