Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs4MIPs project configuration needs tweak #635

Open
durack1 opened this issue May 6, 2024 · 23 comments
Open

obs4MIPs project configuration needs tweak #635

durack1 opened this issue May 6, 2024 · 23 comments

Comments

@durack1
Copy link
Contributor

durack1 commented May 6, 2024

Describe the bug

The metagrid configuration for the obs4MIPs project is a little confused - see https://aims2.llnl.gov/search?project=obs4MIPs - there is a spurious "CMIP5" facet which is empty, see screenshot below. Even the CMIP6 facet is a little mis-named.

Screenshot 2024-05-06 at 3 29 17 PM

To Reproduce

Browse to https://aims2.llnl.gov/search?project=obs4MIPs

@gleckler1 pinging you on this so we can get this cleared up

@sashakames
Copy link
Collaborator

Thanks @durack1 I did not know that all the CMIP5-era data was deleted by now. So agreed lets get this cleaned up right and finalized before any push to the server.

@durack1
Copy link
Contributor Author

durack1 commented May 6, 2024

It would be useful to schedule a chat with @gleckler1 (and possibly @taylor13) to make sure we're not missing any additional opportunities to make search easier for a user

@sashakames
Copy link
Collaborator

Sounds good, a timeframe for releases would be useful for me anyway.

@gleckler1
Copy link

@sashakames @durack1 @taylor13 Great to see the advancements to metagrid! I have three recommendations, the first 2 of which are specific to the obs4MIPs project: 1) remove CMIP5 and CMIP6 from obs4MIPs facets, 2) add a new obs4MIPs facet called "Quick links" with underlying searches to variable_id, source_id and frequency, and 3) enable a capability for some project specific information when first landing project via metagrid (discussed below).

It would be very helpful to display project specific info about the data available via metagrid (typically more specific than the project website). This could be done via a "data info" button below the project website button that links to something like an obs4MIPs_MetaGrid_README.md Even better than a new browser tab (to this README after pushing the data info button) would be if by default when somebody first goes to the project on metagrid the contents of the README are shown in the large Home window where search results are found.

@durack1
Copy link
Contributor Author

durack1 commented May 28, 2024

@sashakames @downiec just looping around on this, is there a chance we can get these GUI tweaks prioritized in the coming month?

@sashakames
Copy link
Collaborator

Sure, I'll see what I can do on esgf-dev1 in the short-term. Peter wanted some additionally changes, too, correct? When he's back we can schedule something.

@sashakames
Copy link
Collaborator

A minimal initial solution is live on esgf-dev1.llnl.gov and I think we can do a production migration soon.

@gleckler1
Copy link

@sashakames dev1 represents real improvement so its great that it can migrate soon. I think for obs4MIPs a next step would be an option for a second button (the first being to the project website). This second button, "Project data info" could be an external link. PG will prepare a link so that when the time comes the button can be prototyped.

@durack1
Copy link
Contributor Author

durack1 commented Jan 7, 2025

@sashakames @downiec can we address this issue soon??

@sashakames
Copy link
Collaborator

I've updated the facets, and we can start work on the second link that is more specific to data information. For the time being users can hopefully get info from the obs4MIPs page linked currently.

@durack1
Copy link
Contributor Author

durack1 commented Jan 7, 2025

Hero, thanks @sashakames.

It seems we have a garbled "Source Idinstitution ID" under identifiers, so would be good to catch that too - otherwise looks great to me!
Screenshot 2025-01-07 at 1 53 00 PM

@sashakames
Copy link
Collaborator

Thank you, there was a missing , between "" "" which Python concats rather than an error, tricky!

@durack1
Copy link
Contributor Author

durack1 commented Jan 7, 2025

@gleckler1 was there anything else to tweak, considering we have @sashakames engaged on this?

@gleckler1
Copy link

gleckler1 commented Jan 7, 2025 via email

@durack1
Copy link
Contributor Author

durack1 commented Feb 13, 2025

@gleckler1 are we good to close this issue?

@gleckler1
Copy link

No. "Obs4MIPs Website" and link to it needs to be replaced with “Obs4MIPs Data Info” (see above for link). Seems to be hard to modify.

@sashakames
Copy link
Collaborator

@downiec What do you think about this request? An additional link next to the website for select projects. If a link is present in the config .json we display it, otherwise just the website link.

@downiec
Copy link
Collaborator

downiec commented Feb 14, 2025

Yes I can work on this next, shouldn't be too difficult, but it will require changes to the database/schema, to accept more than 1 project link because currently the project url comes from the database entry associated with the project

@sashakames
Copy link
Collaborator

Thanks for pointing that out @downiec!

@sashakames
Copy link
Collaborator

I'm getting a bit concerned about "scope creep" with having multiple links to be honest. But it would be fine to rename a single link to something more meaningful.

@downiec downiec mentioned this issue Feb 14, 2025
10 tasks
@downiec
Copy link
Collaborator

downiec commented Feb 14, 2025

We can for the time being, update the link and rename the button, easily enough. To add more than one link, we would need a feature update to make the project_url field more flexible (it's just a string right now), so that we can add in more than one url per project, and potentially specific button labels per url.

@gleckler1
Copy link

Undersood two buttons may required additional special case work. Just changing the link from the homepage to https://pcmdi.github.io/obs4MIPs/dataOnESGF.html would meet the need.

@downiec
Copy link
Collaborator

downiec commented Feb 19, 2025

The link and button names have been updated as requested, the changes are currently on aims2.llnl.gov and are incorporated into our latest v1.3.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants