Skip to content

Exposing or codemodding changed packages #90

@43081j

Description

@43081j

currently we have a few codemods which replace imports.

for example:

const didReplacement = replaceImport(
j,
root,
{ moduleName: 'deep-equal', importName: 'default', cjsNamespace: true },
{ moduleName: 'dequal', importName: 'dequal', cjsNamespace: false },
);

if something (such as the es-t cli) consumes these codemods, it doesn't currently have a way to know what you replaced the import with. we don't expose the fact that we replaced deep-equal with dequal.

in our case, it means the CLI doesn't know which new package to add to package.json.

i think we have two options here:

  1. the codemod owns the job of modifying package.json (by checking the filename or something), and the CLI just calls the codemod on package.json contents
  2. all codemods that affect packages (imports) expose some kind of "result" which defines these (e.g. [{type: 'remove', name: 'deep-equal'}, {type: 'add', name: 'dequal'}])

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions