Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement LISTCORRESPONDENTS #1592

Closed
slingamn opened this issue Mar 11, 2021 · 4 comments
Closed

implement LISTCORRESPONDENTS #1592

slingamn opened this issue Mar 11, 2021 · 4 comments
Labels
release blocker Blocks release
Milestone

Comments

@slingamn
Copy link
Member

From discussion here:

ircv3/ircv3-specifications#444

@slingamn slingamn added this to the v2.6 milestone Mar 11, 2021
@slingamn slingamn added the release blocker Blocks release label Mar 11, 2021
@slingamn
Copy link
Member Author

Note: if we end up removing the * target, we'll no longer need to include nickname targets in the sequence table, with the consequence that entries in sequence will be uniquely identified by sequence.history_id. It will then be possible to reconfigure sequence such that history_id is its primary key: alter table sequence drop column id, add primary key(history_id);.

@slingamn
Copy link
Member Author

Or rather, we won't automatically execute that alter (it will typically fail due to a duplicate key error), but we can change the relevant CREATE TABLE command for new installs without breaking anything, since we never actually query sequence.id.

@slingamn
Copy link
Member Author

This is a little tricky because we currently assume that the timestamp is available in sequences. We could join against both sequences and conversations to get it...

@slingamn
Copy link
Member Author

slingamn commented Apr 8, 2021

The current spec for this is ircv3/ircv3-specifications#450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release blocker Blocks release
Projects
None yet
Development

No branches or pull requests

1 participant