Skip to content

Commit b17c10b

Browse files
committed
fix(lint): disable expect-expect
1 parent a98d72d commit b17c10b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

eslint.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ export const config = [
292292
vitest: (await import('@vitest/eslint-plugin')).default,
293293
},
294294
rules: {
295-
'vitest/expect-expect': ERROR,
296295
// you don't want the editor to autofix this, but we do want to be
297296
// made aware of it
298297
'vitest/no-focused-tests': [WARN, { fixable: false }],
@@ -305,6 +304,9 @@ export const config = [
305304
'vitest/prefer-to-have-length': ERROR,
306305
'vitest/valid-expect-in-promise': ERROR,
307306
'vitest/valid-expect': ERROR,
307+
308+
// vitest/expect-expect - we don't enable this because it's fine to
309+
// rely on testing-library to throw errors if elements aren't found.
308310
},
309311
}
310312
: null,
@@ -317,7 +319,6 @@ export const config = [
317319
playwright: (await import('eslint-plugin-playwright')).default,
318320
},
319321
rules: {
320-
'playwright/expect-expect': ERROR,
321322
'playwright/max-nested-describe': ERROR,
322323
'playwright/missing-playwright-await': ERROR,
323324
'playwright/no-focused-test': WARN,
@@ -336,6 +337,9 @@ export const config = [
336337
'playwright/prefer-web-first-assertions': ERROR,
337338
'playwright/valid-expect-in-promise': ERROR,
338339
'playwright/valid-expect': ERROR,
340+
341+
// playwright/expect-expect - we don't enable this because it's fine to
342+
// rely on thrown errors if elements aren't found.
339343
},
340344
}
341345
: null,

0 commit comments

Comments
 (0)