every test has wildcard mode

Author: zhiyanfoo

pkg/server/stream/v3/subscription.go

@@ -38,8 +38,8 @@ func newSubscription(emptyRequest bool, initialResourceVersions map[string]strin
 	}
 
 	// By default we set the subscription as a wildcard only if the request was empty
-	// and in legacy mode. Later on, outside of this constructor, when we actually 
-	// process the request, if the request was non-empty, it may have an 
+	// and in legacy mode. Later on, outside of this constructor, when we actually
+	// process the request, if the request was non-empty, it may have an
 	// explicit wildcard subscription, in which case
 	// we will set the wildcard field on the subscription accordingly.
 	wildcard := emptyRequest && allowLegacyWildcard

pkg/server/stream/v3/subscription_test.go

@@ -202,6 +202,10 @@ func TestSotwSubscriptionsWithDeactivatedLegacyWildcardForTypes(t *testing.T) {
 		subEndpoint.SetResourceSubscription([]string{})
 		assert.False(t, subEndpoint.IsWildcard())
 
+		// Can still explicitly subscribe to wildcard
+		subEndpoint.SetResourceSubscription([]string{"*"})
+		assert.True(t, subEndpoint.IsWildcard())
+
 		// Route should still have legacy wildcard enabled
 		subRoute := NewSotwSubscription([]string{}, opts, routeType)
 		subRoute.SetResourceSubscription([]string{})
@@ -252,6 +256,10 @@ func TestDeltaSubscriptionsWithDeactivatedLegacyWildcardForTypes(t *testing.T) {
 		subEndpoint.UpdateResourceSubscriptions(nil, nil)
 		assert.False(t, subEndpoint.IsWildcard())
 
+		// Can still explicitly subscribe to wildcard
+		subEndpoint.UpdateResourceSubscriptions([]string{"*"}, nil)
+		assert.True(t, subEndpoint.IsWildcard())
+
 		// Route should still have legacy wildcard enabled
 		subRoute := NewDeltaSubscription([]string{}, []string{}, map[string]string{}, opts, routeType)
 		subRoute.UpdateResourceSubscriptions(nil, nil)