Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to configure HPA for the Envoy Gateway deployment in Helm #4929

Open
arkodg opened this issue Dec 13, 2024 · 1 comment
Open
Labels
area/installation help wanted Extra attention is needed
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Dec 13, 2024

Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

@arkodg arkodg added triage help wanted Extra attention is needed area/installation and removed triage labels Dec 13, 2024
@arkodg arkodg added this to the v1.3.0-rc.1 milestone Dec 13, 2024
@Dean-Coakley
Copy link
Contributor

Dean-Coakley commented Dec 18, 2024

Not sure I understand what is required here.

Would it just be a case of adding something like?:

diff --git a/charts/gateway-helm/values.tmpl.yaml b/charts/gateway-helm/values.tmpl.yaml
index cfcd9532..51517556 100644
--- a/charts/gateway-helm/values.tmpl.yaml
+++ b/charts/gateway-helm/values.tmpl.yaml
@@ -80,6 +80,16 @@ config:
       controllerName: gateway.envoyproxy.io/gatewayclass-controller
     provider:
       type: Kubernetes
+      # envoyHpa:
+      #   minReplicas: 2
+      #   maxReplicas: 10
+      #   metrics:
+      #     - resource:
+      #         name: cpu
+      #         target:
+      #           averageUtilization: 60
+      #           type: Utilization
+      #       type: Resource
     logging:
       level:
         default: info

(Ref: https://gateway.envoyproxy.io/docs/tasks/operations/customize-envoyproxy/#customize-envoyproxy-horizontal-pod-autoscaler)

And then if un-commented I think those entries would get pulled in by the templating in https://github.com/envoyproxy/gateway/blob/main/charts/gateway-helm/templates/envoy-gateway-config.yaml

Or am I misunderstanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/installation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants