Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selection field instrumentation for graphql requests #476

Open
testower opened this issue Jun 4, 2024 · 1 comment · May be fixed by #479
Open

Add selection field instrumentation for graphql requests #476

testower opened this issue Jun 4, 2024 · 1 comment · May be fixed by #479
Assignees
Labels
enhancement New feature or request

Comments

@testower
Copy link
Collaborator

testower commented Jun 4, 2024

Is your feature request related to a problem? Please describe.

GBFS v3 changed a number of fields from simple strings into translated fields. I would like to survey actual usage in the wild
of these fields to see if we can make a breaking change directly in the GraphQL schema for these fields, or if we have to add new fields like "translatedName" alongside the "name" field, and go through a lengthy deprecation phase.

Goal / high level use-case

Add selection field instrumentation

Describe the solution you'd like

See entur/tiamat@7660413 and graphql-java-kickstart/graphql-spring-boot#335 for solution.

This solution is not great, because it involves sifting through large amounts of logs, which is impractical and probably costly.

What we actually need is instrumentation on selection field level similar to what is offered by Apollo GraphQL's field level instrumentation https://www.apollographql.com/docs/apollo-server/api/plugin/usage-reporting. I've yet to find an open and available solution that offers this, so we might have to write one ourselves.

Additional context

This change is related to ongoing work in #412 / #475

@testower testower added the enhancement New feature or request label Jun 4, 2024
@testower testower added this to the 1.1 (next release) milestone Jun 4, 2024
@testower testower self-assigned this Jun 4, 2024
@testower
Copy link
Collaborator Author

testower commented Jun 4, 2024

I'd like to discuss this as well at next meeting @hbruch

@testower testower linked a pull request Jun 10, 2024 that will close this issue
@testower testower changed the title Add request logging instrumentation for graphql requests Add selection field instrumentation for graphql requests Jun 12, 2024
@testower testower modified the milestones: 1.1, 1.2 (next version) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant