Skip to content

Commit f9a9490

Browse files
committed
v2.0.2
1 parent 019c0d2 commit f9a9490

22 files changed

Lines changed: 66 additions & 54 deletions

File tree

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
## 2.0.2
2+
3+
**2023-04-06**
4+
5+
- Change name the following names to avoid conflict with dart/flutter built-in libraries (https://github.com/entronad/graphic/issues/193, https://github.com/entronad/graphic/pull/200):
6+
7+
`View -> ChartView`
8+
9+
`Scene -> MarkScene`
10+
111
## 2.0.1
212

313
**2023-04-04**

DEVLOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,4 +500,6 @@ elements个数不一样的情况太复杂,数据个数不一样时tag也往往
500500

501501
tagEncode 先不要搞默认值了,变量情况复杂不要弄巧成拙,只有在手动改变了data顺序对应被打乱了才要
502502

503-
内部工具函数,尽量保留位置参数或必选参数,哪怕填null,减少错误
503+
内部工具函数,尽量保留位置参数或必选参数,哪怕填null,减少错误
504+
505+
dart似乎有这样一个规定:当import一般lib(import “library: ... 或文件)时,类名不能冲突。但一个是基础库(例如ui)一个是一般lib时没关系,以一般lib优先。ui.Gradient 和 painting.Gradient 是这种情况,ui.Scene 和 graphic.Scene 是这种情况。原则:凡是和官方库(ui,flutter,painting)冲突的命名都要避免,因此这里也要避免。主要采用增加前缀的方法。因此 View 改为 ChartView,Scene改为MarkScene。至于引擎里的Mark一词是否准确,现在先不想了,这里如果要变体系要变,后面3.0再说吧,这里就这样

lib/src/chart/chart.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ class ChartState<D> extends State<Chart<D>> with TickerProviderStateMixin {
186186
/// The view that controlls the data visualization.
187187
///
188188
/// For a chart widget, to "rebuild" means to create a new [view].
189-
View<D>? view;
189+
ChartView<D>? view;
190190

191191
/// Size of the chart widget.
192192
///
@@ -745,7 +745,7 @@ class _ChartLayoutDelegate<D> extends SingleChildLayoutDelegate {
745745
// to create a new view. A view is and only is created in _ChartLayoutDelegate.getPositionForChild
746746
// because it needs the current size.
747747

748-
state.view = View<D>(
748+
state.view = ChartView<D>(
749749
state.widget,
750750
size,
751751
state,

lib/src/chart/view.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import 'chart.dart';
1212
import 'size.dart';
1313

1414
/// The dataflow graph of a chart.
15-
class View<D> extends Dataflow {
16-
View(
15+
class ChartView<D> extends Dataflow {
16+
ChartView(
1717
Chart<D> spec,
1818
Size size,
1919
TickerProvider tickerProvider,
@@ -38,17 +38,17 @@ class View<D> extends Dataflow {
3838

3939
/// The gesture event stream.
4040
///
41-
/// This is generated in [parse] and hold by [View] for internal interactions.
41+
/// This is generated in [parse] and hold by [ChartView] for internal interactions.
4242
late StreamController<GestureEvent> gestureStream;
4343

4444
/// The resize event stream.
4545
///
46-
/// This is generated in [parse] and hold by [View] for internal interactions.
46+
/// This is generated in [parse] and hold by [ChartView] for internal interactions.
4747
late StreamController<ResizeEvent> resizeStream;
4848

4949
/// The changeData event stream.
5050
///
51-
/// This is generated in [parse] and hold by [View] for internal interactions.
51+
/// This is generated in [parse] and hold by [ChartView] for internal interactions.
5252
late StreamController<ChangeDataEvent<D>> changeDataStream;
5353

5454
/// Emits a gesture event.

lib/src/common/operators/render.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:graphic/src/dataflow/operator.dart';
33
import 'package:graphic/src/graffiti/element/element.dart';
44
import 'package:graphic/src/graffiti/scene.dart';
55

6-
/// The operator to render [MarkElement]s to a [Scene].
6+
/// The operator to render [MarkElement]s to a [MarkScene].
77
///
88
/// Render operators are sink nodes of the dataflow. It has no value, and the rendering
99
/// is a side effect. The [scene] is set in constructor and unchangable.
@@ -15,12 +15,12 @@ abstract class Render extends Operator {
1515
) : super(params);
1616

1717
/// The scene to render.
18-
final Scene scene;
18+
final MarkScene scene;
1919

2020
/// The view.
2121
///
22-
/// It is imported to mark [View.dirty].
23-
final View view;
22+
/// It is imported to mark [ChartView.dirty].
23+
final ChartView view;
2424

2525
@override
2626
evaluate() {

lib/src/coord/coord.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class RegionOp extends Operator<Rect> {
133133
abstract class RegionBackgroundRenderOp extends Render {
134134
RegionBackgroundRenderOp(
135135
Map<String, dynamic> params,
136-
Scene scene,
137-
View view,
136+
MarkScene scene,
137+
ChartView view,
138138
) : super(params, scene, view);
139139
}

lib/src/coord/polar.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,8 +282,8 @@ class PolarCoordConvOp extends CoordConvOp<PolarCoordConv> {
282282
class PolarRegionColorRenderOp extends RegionBackgroundRenderOp {
283283
PolarRegionColorRenderOp(
284284
Map<String, dynamic> params,
285-
Scene scene,
286-
View view,
285+
MarkScene scene,
286+
ChartView view,
287287
) : super(params, scene, view);
288288

289289
@override
@@ -306,8 +306,8 @@ class PolarRegionColorRenderOp extends RegionBackgroundRenderOp {
306306
class PolarRegionGradientRenderOp extends RegionBackgroundRenderOp {
307307
PolarRegionGradientRenderOp(
308308
Map<String, dynamic> params,
309-
Scene scene,
310-
View view,
309+
MarkScene scene,
310+
ChartView view,
311311
) : super(params, scene, view);
312312

313313
@override

lib/src/coord/rect.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ class RectCoordConvOp extends CoordConvOp<RectCoordConv> {
171171
class RectRegionColorRenderOp extends RegionBackgroundRenderOp {
172172
RectRegionColorRenderOp(
173173
Map<String, dynamic> params,
174-
Scene scene,
175-
View view,
174+
MarkScene scene,
175+
ChartView view,
176176
) : super(params, scene, view);
177177

178178
@override
@@ -188,8 +188,8 @@ class RectRegionColorRenderOp extends RegionBackgroundRenderOp {
188188
class RectRegionGradientRenderOp extends RegionBackgroundRenderOp {
189189
RectRegionGradientRenderOp(
190190
Map<String, dynamic> params,
191-
Scene scene,
192-
View view,
191+
MarkScene scene,
192+
ChartView view,
193193
) : super(params, scene, view);
194194

195195
@override

lib/src/graffiti/element/element.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ abstract class ElementStyle {
2020
bool operator ==(Object other) => other is ElementStyle;
2121
}
2222

23-
/// The basic element to compose graphics on [Scene]s.
23+
/// The basic element to compose graphics on [MarkScene]s.
2424
abstract class MarkElement<S extends ElementStyle> {
2525
/// Creates an element.
2626
MarkElement({

lib/src/graffiti/graffiti.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ class Graffiti {
2020
final void Function() repaint;
2121

2222
/// The scenes to paint.
23-
final _scenes = <Scene>[];
23+
final _scenes = <MarkScene>[];
2424

2525
/// Creates a scene, add it to graffiti, and returns this scene.
26-
Scene createScene({
26+
MarkScene createScene({
2727
int layer = 0,
2828
int builtinLayer = 0,
2929
Transition? transition,
3030
}) {
31-
final scene = Scene(
31+
final scene = MarkScene(
3232
layer: layer,
3333
builtinLayer: builtinLayer,
3434
transition: transition,
@@ -40,7 +40,7 @@ class Graffiti {
4040

4141
/// Sorts [_scenes].
4242
///
43-
/// The priority of comparing is [Scene.layer] > [Scene.builtinLayer].
43+
/// The priority of comparing is [MarkScene.layer] > [MarkScene.builtinLayer].
4444
void sort() {
4545
for (var i = 0; i < _scenes.length; i++) {
4646
_scenes[i].preIndex = i;

0 commit comments

Comments
 (0)