Feat/issue screenshot aspect ratio#1240
Closed
calebbrooksdev-ctrl wants to merge 2 commits into
Closed
Conversation
Author
|
@anderdc Please check this PR. |
anderdc
requested changes
May 22, 2026
Collaborator
anderdc
left a comment
anderdc
left a comment
There was a problem hiding this comment.
The real bug here is the aspect-ratio distortion; the lightbox is bundled scope that isn't needed.
Keep: the image-sizing fix in ConversationTimeline.tsx — width: auto / height: auto / object-fit: contain on the markdown img rule. That alone fixes #1234's reported bug; GitHub's attributes were forcing the distorted ratio.
Drop: ImageLightbox.tsx, MarkdownImage.tsx, the conversationMarkdownComponents img/a overrides in ConversationTimeline.tsx, and the two common/index.ts exports. A full-screen in-app modal duplicates just opening the screenshot — the lightbox's own "Open in new tab" button is the behavior we already have.
Author
|
It fixes #1234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New Feature - Added a image lightbox for screenshot
Related Issues
Issue #1234
Type of Change
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpassesScreenshots
After Fix & Update