fix(cache): back the response cache with Redis on cache-manager v7 (#108)

* fix(cache): back the response cache with Redis on cache-manager v7

The cache module was copied from das-gittensor (@nestjs/cache-manager
v2 / cache-manager v5). das-github-mirror is on v3 / cache-manager v7
(Keyv-based), where the config shape changed, so the copied config was
broken on arrival in b771271:

- v3 reads the store list from `stores` (plural Keyv instances); the
  singular `store` key was ignored, so Redis was never used.
- v3 reads the entry TTL from top-level `ttl`; the `ttl` nested inside
  `redisStore({ ttl })` never reached the cache.

Production therefore ran an in-memory cache with no expiry — GET
responses were pinned from process start and served stale until the
next restart (~20h stale observed on /api/v1/miners/:id/issues).

- Replace cache-manager-redis-yet (v5-era, incompatible with v7) with
  @keyv/redis.
- Pass `stores: [Keyv]` + top-level `ttl`.
- Namespace cache keys `apicache`, clear of BullMQ's `bull:*`.
- Add a store error listener so a Redis blip degrades to an uncached
  request instead of crashing the process.
- Type the factory return as CacheModuleOptions (was `any`).

* fix(cache): regenerate package-lock.json with npm 10

The previous commit's lockfile was generated with npm 11 (local), which
CI's npm 10 (Node 20) rejected as out of sync — `npm ci` reported the
chokidar subtree missing from the lock. Regenerated with npm 10 so the
lockfile format matches CI; `npm ci` now passes locally under npm 10.

---------

Co-authored-by: anderdc <me@alexanderdc.com>

Author: anderdc

packages/das/package-lock.json

@@ -17,6 +17,7 @@
     "lint:fix": "eslint \"src/**/*.ts\" --fix"
   },
   "dependencies": {
+    "@keyv/redis": "^5.1.6",
     "@nestjs/bullmq": "^11.0.4",
     "@nestjs/cache-manager": "^3.1.0",
     "@nestjs/common": "^10.0.0",
@@ -26,8 +27,8 @@
     "@nestjs/swagger": "^7.4.2",
     "@nestjs/typeorm": "^10.0.2",
     "bullmq": "^5.74.1",
-    "cache-manager-redis-yet": "^5.1.5",
     "jsonwebtoken": "^9.0.3",
+    "keyv": "^5.6.0",
     "pg": "^8.16.3",
     "reflect-metadata": "^0.2.0",
     "rxjs": "^7.8.1",

packages/das/package.json

@@ -1,7 +1,8 @@
-import { CacheModule } from "@nestjs/cache-manager";
-import { Global, Module } from "@nestjs/common";
+import { CacheModule, CacheModuleOptions } from "@nestjs/cache-manager";
+import { Global, Logger, Module } from "@nestjs/common";
 import { APP_INTERCEPTOR } from "@nestjs/core";
-import { redisStore } from "cache-manager-redis-yet";
+import KeyvRedis from "@keyv/redis";
+import { Keyv } from "keyv";
 import { CustomCacheInterceptor } from "./custom-cache.interceptor";
 
 // Production TTL for cached API responses (scoring cycles run far less often)
@@ -11,26 +12,42 @@ const DEV_CACHE_TTL_MS = 1;
 
 const isProduction = process.env.NODE_ENV === "production";
 
+const logger = new Logger("CustomCacheModule");
+
 @Global()
 @Module({
   imports: [
     CacheModule.registerAsync({
       isGlobal: true,
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      useFactory: async (): Promise<any> => {
+      useFactory: (): CacheModuleOptions => {
         const ttl = isProduction ? CACHE_TTL_MS : DEV_CACHE_TTL_MS;
 
+        // @nestjs/cache-manager v3 (cache-manager v7 / Keyv) reads the store
+        // list from `stores` (plural — Keyv instances) and the entry TTL from
+        // the top-level `ttl`. A singular `store`, or a `ttl` nested inside a
+        // store adapter, is silently ignored: the cache then falls back to an
+        // in-memory store with no expiry. Keep both at the top level.
         if (process.env.REDIS_HOST) {
-          return {
-            store: await redisStore({
-              socket: {
-                host: process.env.REDIS_HOST,
-                port: parseInt(process.env.REDIS_PORT ?? "6379"),
-              },
-              ttl,
-            }),
-          };
+          const host = process.env.REDIS_HOST;
+          const port = process.env.REDIS_PORT ?? "6379";
+
+          // `apicache` namespace keeps response-cache keys clear of the
+          // BullMQ (`bull:*`) keyspace on the shared Redis instance.
+          const store = new Keyv({
+            store: new KeyvRedis(`redis://${host}:${port}`),
+            namespace: "apicache",
+          });
+          // Surface — and swallow — Redis connection errors so a Redis blip
+          // degrades to an uncached request rather than an unhandled
+          // EventEmitter "error" that would crash the process.
+          store.on("error", (err) =>
+            logger.error(`Redis response cache error: ${String(err)}`),
+          );
+
+          return { ttl, stores: [store] };
         }
+
+        // No Redis configured — fall back to the built-in in-memory store.
         return { ttl };
       },
     }),