Fix Copilot review issues

- store.go: Init header before append, validate version in Load
- builder.go: Use cpID.Path() for checkpoint root directory
- list.go/show.go/index_cmd.go: Use paths.WorktreeRoot() for repo root
- index_cmd.go: Implement actual rebuild logic
- search.go: Fix Use string to match Args requirement

Entire-Checkpoint: 3e555fd3bee4

Author: AasheeshLikePanner

cmd/entire/cli/prompts/index/builder.go

@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
-	"path/filepath"
 	"strconv"
 	"strings"
 	"time"
@@ -163,9 +162,7 @@ func walkCheckpointShards(repo *git.Repository, treeHash plumbing.Hash, fn func(
 }
 
 func (b *Builder) loadCheckpoint(cpID id.CheckpointID) ([]Entry, error) {
-	shard := cpID.String()[:2]
-	rest := cpID.String()[2:]
-	cpDir := filepath.Join(shard, rest, "0")
+	cpDir := cpID.Path()
 
 	ref, err := b.repo.Reference(plumbing.NewBranchReferenceName(paths.MetadataBranchName), true)
 	if err != nil {
@@ -211,7 +208,7 @@ func (b *Builder) loadCheckpoint(cpID id.CheckpointID) ([]Entry, error) {
 
 	entries := make([]Entry, 0)
 	for i := range metadata.Sessions {
-		sessionDir := filepath.Join(cpDir, strconv.Itoa(i))
+		sessionDir := strconv.Itoa(i)
 		sessionTree, err := cpTree.Tree(sessionDir)
 		if err != nil {
 			continue

cmd/entire/cli/prompts/index/store.go

@@ -81,6 +81,12 @@ func (s *Store) Load(_ context.Context) ([]Entry, error) {
 			if err := json.Unmarshal([]byte(line), &header); err != nil {
 				return nil, fmt.Errorf("%w: header: %w", ErrIndexCorrupt, err)
 			}
+			if header.Version <= 0 {
+				return nil, fmt.Errorf("%w: header: invalid version %d", ErrIndexCorrupt, header.Version)
+			}
+			if header.Version > CurrentIndexVersion {
+				return nil, ErrIndexVersionNewer
+			}
 		} else {
 			var entry Entry
 			if err := json.Unmarshal([]byte(line), &entry); err != nil {
@@ -138,6 +144,13 @@ func (s *Store) AppendEntries(entries []Entry) error {
 }
 
 func (s *Store) appendEntriesLine(entries []Entry) error {
+	fi, err := os.Stat(s.indexPath)
+	if err != nil || fi.Size() == 0 {
+		if err := s.InitIndex(); err != nil {
+			return fmt.Errorf("initializing index: %w", err)
+		}
+	}
+
 	f, err := os.OpenFile(s.indexPath, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0o600)
 	if err != nil {
 		return fmt.Errorf("opening index for append: %w", err)

cmd/entire/cli/prompts/index_cmd.go

@@ -2,10 +2,13 @@ package prompts
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 
+	"github.com/entireio/cli/cmd/entire/cli/paths"
 	"github.com/entireio/cli/cmd/entire/cli/prompts/index"
+	"github.com/entireio/cli/cmd/entire/cli/strategy"
 	"github.com/spf13/cobra"
 )
 
@@ -40,14 +43,39 @@ Examples:
 func runIndex(ctx context.Context, w io.Writer, ew io.Writer, rebuild, status, verify bool) error {
 	_ = ew
 
+	repoRoot, err := paths.WorktreeRoot(ctx)
+	if err != nil {
+		return errors.New("not a git repository")
+	}
+
 	if rebuild {
-		fmt.Fprintln(w, "Rebuilding index...")
-		fmt.Fprintln(w, "(Use 'entire prompts search' to trigger automatic rebuild if index is missing)")
+		repo, err := strategy.OpenRepository(ctx)
+		if err != nil {
+			return fmt.Errorf("opening repository: %w", err)
+		}
+
+		store := index.NewStore(repoRoot)
+		builder := index.NewBuilder(repo, store)
+
+		fmt.Fprintln(w, "Rebuilding prompt index from checkpoints...")
+
+		progressFn := func(done, total int) {
+			if total > 0 {
+				fmt.Fprintf(w, "\r  %d / %d checkpoints", done, total)
+			}
+		}
+
+		if err := builder.Build(ctx, w, progressFn); err != nil {
+			return fmt.Errorf("building index: %w", err)
+		}
+
+		fmt.Fprintln(w, "")
+		fmt.Fprintln(w, "Index rebuild complete.")
 		return nil
 	}
 
 	if status {
-		store := index.NewStore("")
+		store := index.NewStore(repoRoot)
 		stats, err := store.Stats(ctx)
 		if err != nil {
 			return fmt.Errorf("getting stats: %w", err)
@@ -70,6 +98,7 @@ func runIndex(ctx context.Context, w io.Writer, ew io.Writer, rebuild, status, v
 
 	if verify {
 		fmt.Fprintln(w, "Verifying index entries...")
+		fmt.Fprintln(w, "(Use 'entire prompts search' to trigger automatic rebuild if index is missing)")
 		return nil
 	}
 

cmd/entire/cli/prompts/list.go

@@ -7,6 +7,7 @@ import (
 	"io"
 	"strings"
 
+	"github.com/entireio/cli/cmd/entire/cli/paths"
 	"github.com/entireio/cli/cmd/entire/cli/prompts/index"
 	"github.com/spf13/cobra"
 )
@@ -32,7 +33,12 @@ Examples:
 }
 
 func runList(ctx context.Context, w io.Writer, _ io.Writer, limit int) error {
-	store := index.NewStore("")
+	repoRoot, err := paths.WorktreeRoot(ctx)
+	if err != nil {
+		return errors.New("not a git repository")
+	}
+
+	store := index.NewStore(repoRoot)
 
 	if !store.Exists() {
 		fmt.Fprintln(w, "No prompt index found. Run 'entire prompts index --rebuild' first.")

cmd/entire/cli/prompts/search.go

@@ -27,7 +27,7 @@ func newSearchCmd() *cobra.Command {
 	)
 
 	cmd := &cobra.Command{
-		Use:   "search [query]",
+		Use:   "search <query>",
 		Short: "Search prompts from checkpoint history",
 		Long: `Search prompts from your checkpoint history by keywords.
 

cmd/entire/cli/prompts/show.go

@@ -2,9 +2,11 @@ package prompts
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"io"
 
+	"github.com/entireio/cli/cmd/entire/cli/paths"
 	"github.com/entireio/cli/cmd/entire/cli/prompts/index"
 	"github.com/spf13/cobra"
 )
@@ -28,7 +30,12 @@ Examples:
 }
 
 func runShow(ctx context.Context, w io.Writer, cpIDPrefix string) error {
-	store := index.NewStore("")
+	repoRoot, err := paths.WorktreeRoot(ctx)
+	if err != nil {
+		return errors.New("not a git repository")
+	}
+
+	store := index.NewStore(repoRoot)
 	entries, err := store.Load(ctx)
 	if err != nil {
 		return fmt.Errorf("loading index: %w", err)