Option name and value are reversed

[sbj42]

The sample code in README.md shows how the displayed option string and the corresponding answer string can be different. But running the example seems to have the two strings reversed.

For instance:

    {
      key: 'a',
      name: 'Overwrite this one and all next',
      value: 'overwrite_all'
    },

I would expect this to display as Overwrite this one and all next. But here is what I get when I run that sample:

? What action should be taken on file.js?  (yadXh)
  overwrite
  overwrite_all
  diff
 ────────
  abort
  Help
  Answer:

[jonschlinkert]

Your issues are awesome! thank you. Well written and very clear, which makes it easy to act on and fix the problems described. again, thank you! I'm on it

[sbj42]

No problem. This one I thought I might have miscategorized. I went digging and I think part the issue is actually all the way down in prompt-choices, but I don't understand enough of the layers to trace it properly.

In general it looks like value is initialized from name, but then their usage gets muddled, e.g. in Choice.prototype.render:

Choice.prototype.render = function(idx, options) {
 // ...
    return this.value;

And Choice's line property:

Object.defineProperty(Choice.prototype, 'line', {
  // ...
  set: function(line) {
    if (typeof line === 'string') this.value = line;

And up in prompt-checkbox at Checkbox.prototype.renderAnswer:

Checkbox.prototype.renderAnswer = function() {
  var keys = this.choices.checked.map(function(choice) {
    return typeof choice === 'string' ? choice : choice.value;

I'm sure you've got a better grasp than I do of the implications here, but it does look like this particular one is pretty pervasive.

[jonschlinkert]

I already have a fix for this I think. Somewhere along the way I guess I removed support for the .format option, which was passed to each choice to format the line. no, I didn't remove it lol. I just need to fix the logic here. Working on it now.

fwiw, I probably did this because we've been refactoring incrementally to get closer to using a redux-like stateless object for rendering. Soon, when I have enough time, I'll just refactor everything to do that at once. The APIs for Enquirer and prompts shouldn't change much if at all, but it will make it much easier to understand how the prompts work internally, how to customize them, and how to debug for stuff like this.