[FIX] ClearIcon's ContentView needs to be initially visible in order to receive Binding updates

Author: StepKie

src/UraniumUI.Material/Controls/TextField.BindableProperties.cs

@@ -16,7 +16,7 @@ public partial class TextField
         typeof(TextField),
         string.Empty,
         BindingMode.TwoWay,
-        propertyChanging: (bindable, oldValue, newValue) =>
+        propertyChanged: (bindable, oldValue, newValue) =>
         {
             (bindable as TextField).UpdateClearIconState();
         });

src/UraniumUI.Material/Controls/TextField.cs

@@ -1,4 +1,5 @@
 using Microsoft.Extensions.Logging;
+using Microsoft.Maui.Controls;
 using Plainer.Maui.Controls;
 using System.Windows.Input;
 using UraniumUI.Converters;
@@ -167,7 +168,7 @@ protected virtual View CreateIconClear()
         {
             VerticalOptions = LayoutOptions.Center,
             HorizontalOptions = LayoutOptions.End,
-            IsVisible = false,
+            IsVisible = true, // this is important; having initial state of false will have SetBinding have no effect, since it will not receive input events
             Padding = new Thickness(5, 0),
             Margin = new Thickness(0, 0, 5, 0),
             TappedCommand = new Command(OnClearTapped),
@@ -178,12 +179,14 @@ protected virtual View CreateIconClear()
                 Fill = ColorResource.GetColor("OnBackground", "OnBackgroundDark", Colors.DarkGray).WithAlpha(.5f),
             }
         };
+
         contentView.SetId("ClearIcon");
         contentView.SetBinding(StatefulContentView.IsFocusableProperty, new Binding(nameof(DisallowClearButtonFocus), source: this));
-        contentView.SetBinding(StatefulContentView.IsVisibleProperty, new Binding(nameof(Text), converter: UraniumConverters.StringIsNotNullOrEmptyConverter, source: this));
+        contentView.SetBinding(IsVisibleProperty, new Binding(nameof(Text), converter: UraniumConverters.StringIsNotNullOrEmptyConverter, source: this));
+
         return contentView;
     }
-
+  
     /// <summary>
     /// Input has be be already focused when this method is called.
     /// </summary>

test/UraniumUI.Material.Tests/Controls/TextField_Test.cs

@@ -4,6 +4,8 @@
 using System.Windows.Input;
 using UraniumUI.Material.Controls;
 using UraniumUI.Tests.Core;
+using UraniumUI.ViewExtensions;
+using UraniumUI.Views;
 
 namespace UraniumUI.Material.Tests.Controls;
 public class TextField_Test
@@ -40,23 +42,23 @@ public void Text_Binding_FromSource()
         control.Text.ShouldBe(viewModel.Text);
     }
 
-	[Fact]
-	public void Text_Binding_RaisesPropertyChangedEvent_ExactlyOnce()
-	{
-		var control = AnimationReadyHandler.Prepare(new TextField());
-		var viewModel = new TestViewModel { Text = "Text Initial Value" };
-		control.BindingContext = viewModel;
-		control.SetBinding(TextField.TextProperty, new Binding(nameof(TestViewModel.Text)));
+    [Fact]
+    public void Text_Binding_RaisesPropertyChangedEvent_ExactlyOnce()
+    {
+        var control = AnimationReadyHandler.Prepare(new TextField());
+        var viewModel = new TestViewModel { Text = "Text Initial Value" };
+        control.BindingContext = viewModel;
+        control.SetBinding(TextField.TextProperty, new Binding(nameof(TestViewModel.Text)));
 
-		var monitoredSubject = control.Monitor();
-		// Act
-		viewModel.Text = "Changed Value";
+        var monitoredSubject = control.Monitor();
+        // Act
+        viewModel.Text = "Changed Value";
 
-		// Assert
-		monitoredSubject.Should().RaisePropertyChangeFor(x => x.Text).ShouldHaveSingleItem();
-	}
+        // Assert
+        monitoredSubject.Should().RaisePropertyChangeFor(x => x.Text).ShouldHaveSingleItem();
+    }
 
-	[Fact]
+    [Fact]
     public void Text_Binding_ToSource()
     {
         var control = AnimationReadyHandler.Prepare(new TextField());
@@ -91,6 +93,23 @@ public void TextProperty_Parent_ShouldTwoWayBind_Child()
         control.Text.ShouldBe(control.EntryView.Text);
     }
 
+    [Fact]
+    public void TextChanges_ShouldShouldCorrectlyUpdateClearButtonVisibility()
+    {
+        var control = AnimationReadyHandler.Prepare(new TextField() { AllowClear = true });
+        // Currently no easier way provided by TextField/InputField to access this control
+        var clearIcon = control.FindByViewQueryIdInVisualTreeDescendants<StatefulContentView>("ClearIcon");
+
+        // Since we initialized with AllowClear = true
+        clearIcon.Should().NotBeNull();
+        // TextField initialized without text -> clear icon should be initially hidden
+        clearIcon.IsVisible.ShouldBeFalse();
+        control.Text = "Test";
+        clearIcon.IsVisible.ShouldBeTrue();
+        control.Text = "";
+        clearIcon.IsVisible.ShouldBeFalse();
+    }
+
     [Fact]
     public void SelectionLength_ShouldBeSent_ToViewModel()
     {