remove BLE dependency for Battery widget

[kumbung01]

hello, thank you for this repo,

I'm currently using ESB for connection, which is capable of reporting battery level.

however, the dependency for BLE prevents from initializing battery widget.

Can you remove dependency for BLE with battery widget?

you just have to remove IS_ENABLED(CONFIG_ZMK_BLE), and it works fine.

thank you.

the code is in custom_status_screen.c, line 76.
#if IS_ENABLED(CONFIG_ZMK_BATTERY) && IS_ENABLED(CONFIG_ZMK_BLE) zmk_widget_dongle_battery_status_init(&dongle_battery_status_widget, screen); lv_obj_align(zmk_widget_dongle_battery_status_obj(&dongle_battery_status_widget), LV_ALIGN_TOP_RIGHT, 0, 0); #endif

[englmaxi]

Hi, there is no dependency in the line you mentioned. (custom_status_screen.c#L76)

I noticed that the ESB module was recently updated to support battery reporting (badjeff/zmk-feature-split-esb@3d3e707). Could you please check if everything is now functioning without any changes to this module by following the new instructions in the README file? Thanks.

[kumbung01]

sorry, my mistake ㅠㅠ I think I have forked your code and changed it when ESB doesn't support battery report
thanks for your answer

[kumbung01]

the reason was

#ifndef ZMK_SPLIT_BLE_PERIPHERAL_COUNT
#  define ZMK_SPLIT_BLE_PERIPHERAL_COUNT 0
#endif

which 'needs' to be BLE on, by

#define ZMK_BLE_IS_CENTRAL                                                                         \
    (IS_ENABLED(CONFIG_ZMK_SPLIT_BLE) && IS_ENABLED(CONFIG_ZMK_SPLIT_ROLE_CENTRAL))

#if ZMK_BLE_IS_CENTRAL
#define ZMK_BLE_PROFILE_COUNT (CONFIG_BT_MAX_PAIRED - CONFIG_ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS)
#define ZMK_SPLIT_BLE_PERIPHERAL_COUNT CONFIG_ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS
#else
#define ZMK_BLE_PROFILE_COUNT CONFIG_BT_MAX_PAIRED
#endif

SPLIT_BLE was not on, so no ZMK_SPLIT_BLE_PERIPHERAL_COUNT

so guess I just have to fork your code and define it by myself...

[englmaxi]

In the before mentioned commit of the ESB module ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS is defined.
When I have time i'll use this symbol instead of ZMK_SPLIT_BLE_PERIPHERAL_COUNT. This way you won't have to maintain a fork.

Sry for the inconvenience, I'll let you know when I have made the change.

[badjeff]

You could try CONFIG_COMPILER_OPT to add back the macro derivatives guarded by #if ZMK_BLE_IS_CENTRAL.
Or, appends CC FLAG via west build with -D

CONFIG_ZMK_SPLIT_BLE_CENTRAL_PERIPHERALS=2
CONFIG_COMPILER_OPT="-DZMK_SPLIT_BLE_PERIPHERAL_COUNT=2"

[ModestoHagney]

Could this be why I can't get peripheral battery levels to display?

[englmaxi]

Could this be why I can't get peripheral battery levels to display?

If you are not using zmk-feature-split-esb this should not be relevant for you.

Are you still facing a issue?

[ModestoHagney]

Oh esb, no. Yeah I'm still struggling to get battery levels to show.

I've tried so many options so far I assume I've turned on something that's conflicting.

Currently before I turn my peripherals on I see one battery level reading 0%, then once they have connected the 0% disappears and the area just stays blank.

[englmaxi]

I think your configuration looks good. Is there a reason why you added a vbatt node to the device tree? Battery monitoring should work by default on a nice_nano_v2 (-> it is also more likely that you have the v2-version).

[ModestoHagney]

It was just one of the many things I tried to get it working. They are nicenano v2 clones. Not sure if that makes a difference.

[englmaxi]

It was just one of the many things I tried to get it working. They are nicenano v2 clones. Not sure if that makes a difference.

I would try removing the node and changing it to nice_nano_v2. You would need to reflash both halves.

[ModestoHagney]

I have a feeling tried that. I might be getting mixed up with something else, but I have it pinned to zmk v3.0 because main wouldn't compile with nice_nano_v2.

I'll give it a shot though and let you know how it goes.

Edit: That did the trick! Thank you for the help!