Skip to content

Commit 05cdb5f

Browse files
authored
refactor(memoize): depend on harden, not ses (#3107)
Closes: #XXXX Refs: #3108 ## Description `@endo/memoize` is a tiny package that had depended on `'ses'` only for `harden`. It is a great example of why we factored `harden` out into an importable `@endo/harden`. The PR changes `@endo/memoize` to depend directly on `endo@harden` rather than `ses`. ### Security Considerations @endo/harden enables non-protecting hardens, but only when protection is off in general. @endo/memoize only provides its strong guarantees when @endo/harden is fully protecting. This is all consistent, so I would say: No weakening of security. ### Scaling Considerations A bit. It means other packages can depend on @endo/memoize without bringing in all of ses. ### Documentation Considerations none ### Testing Considerations - [x] Should do the multi-ses-ava mode testing that @kriskowal set up. Addendum: happy to find that it already happens without my needing to do anything. Thanks @kriskowal ! ### Compatibility Considerations none ### Upgrade Considerations none
1 parent d1d9625 commit 05cdb5f

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

.changeset/thin-toes-mix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@endo/memoize': patch
3+
---
4+
5+
`@endo/memoize` no longer depends on `ses`, just `@endo/harden`

packages/memoize/index.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
/// <reference types="ses"/>
2-
31
export * from './src/memoize.js';

packages/memoize/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
"test:c8": "c8 ${C8_OPTIONS:-} ses-ava"
3636
},
3737
"dependencies": {
38-
"@endo/harden": "workspace:^",
39-
"ses": "workspace:^"
38+
"@endo/harden": "workspace:^"
4039
},
4140
"devDependencies": {
4241
"@endo/init": "workspace:^",

yarn.lock

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,6 @@ __metadata:
903903
ava: "catalog:dev"
904904
c8: "catalog:dev"
905905
eslint: "catalog:dev"
906-
ses: "workspace:^"
907906
typescript: "npm:~5.9.2"
908907
languageName: unknown
909908
linkType: soft

0 commit comments

Comments
 (0)