Skip to content

Flush the stdout buffer on Windows to trigger reload #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 14, 2025
Merged

Flush the stdout buffer on Windows to trigger reload #2604

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
657f0f0
Improve reloading on Windows
jamesh1999 Mar 28, 2025
ba87386
Fix lint
jamesh1999 Mar 28, 2025
716446b
Changes
jamesh1999 Apr 13, 2025
e34ab31
Fix lint
jamesh1999 Apr 13, 2025
94a80d2
Merge branch 'master' into bugfix/reload-hangs-on-windows
Kludex Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions uvicorn/supervisors/basereload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ def restart(self) -> None:
self.is_restarting = True
assert self.process.pid is not None
os.kill(self.process.pid, signal.CTRL_C_EVENT)

# This is a workaround to ensure the Ctrl+C event is processed
sys.stdout.write(" ") # This has to be a non-empty string
sys.stdout.flush()
else: # pragma: py-win32
self.process.terminate()
self.process.join()
Expand Down