Repository navigation
relax reload_dirs to allow files, and stop adding cwd when reload_dirs is set - #2583
Closed
adhami3310 wants to merge 3 commits into
Closed
adhami3310 wants to merge 3 commits into
adhami3310 wants to merge 3 commits into
Conversation
stinovlas
approved these changes
Mar 14, 2025
stinovlas
left a comment
stinovlas
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! I bumped into the issue with --reload-dir not behaving like documentation states and this should fix it. Hopefully some maintainer will pick it up soon :-).
3 tasks done
ateijelo
reviewed
May 20, 2025
| self.reload_dirs.append(directory) | ||
| if Path.cwd() not in self.reload_dirs: | ||
| self.reload_dirs.append(Path.cwd()) | ||
| self.reload_dirs.append(directory) |
There was a problem hiding this comment.
maybe just do self.reload_dirs = config.reload_dirs ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on the discussion on #1833 the behavior currently done by a uvicorn is intuitive and most likely will lead to bugs by downstream users. It's also the case that watchfiles can watch individual files, as such it's a manufactured constraint by uvicorn is very arbitrary. Some other ASGIs just has
reload_paths, that handles files just fine. I didn't change the variable name to not break backwards compatibility, but the former change can be seen as breaking, even if the existing behavior can be considered as a bug.Checklist
I'm not familiar with the larger project, so I will be holding off on documentation and tests until it's verified that the project has interest in the change getting merged.