From c7ef13a0900eeec8ba1e6fae3984f31f803892c4 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Mon, 9 Jun 2025 14:56:33 -0700 Subject: [PATCH] Fix create_release.py script to handle bad underlines The script was assuming the underline was the same length as the title itself. e.g. it did not handle. ``` 1.3.4 (in development) ------------------- ``` See #24516 --- tools/maint/create_release.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/maint/create_release.py b/tools/maint/create_release.py index 54ef3135f0789..adfd1a1d00f8b 100755 --- a/tools/maint/create_release.py +++ b/tools/maint/create_release.py @@ -28,7 +28,11 @@ def update_changelog(release_version, new_version): marker = f'{release_version} (in development)' pos = changelog.find(marker) assert pos != -1 - pos += 2 * len(marker) + 1 + pos += len(marker) + 1 + # Skip the next line which should just be hyphens + assert changelog[pos] == '-' + pos = changelog.find('\n', pos) + assert pos != -1 # Add new entry today = datetime.now().strftime('%m/%d/%y')