-
Notifications
You must be signed in to change notification settings - Fork 3.4k
BigInt literals in JS libraries do not compile #13297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Looks like there is plan for upgrade #12410. I would hope that fixing that would also fix this? |
Yes, an upgrade is needed. For now, |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
@sbc100 is this fixed? |
Yes! |
I'm still getting this error after pulling the latest changes from this repository. What am I missing :)? Edit: |
@firasdib what error exactly are you seeing? Which version of emscripten works for and which one breaks? How are you installing emscripten? |
I cloned the repo and ran:
After compiling .NET 7 with
|
Can you try building with |
Here is the file |
Sorry EMCC_DEBUG_SAVE=1 is an environment variable, not and emscripten setting. |
It looks like the problematic statement is the call the import function here:
It doesn't looks like that code comes from emscripten itself... So you know if used to work in the past? What version of emscripten did this last work with? |
Ah, makes sense.
This is the latest RC1 of .NET 7, first time trying it. The previous preview builds worked fine, so probably something new they introduced that breaks it.
Thanks for looking into it.
… On 17 Jul 2022, at 18:24, Sam Clegg ***@***.***> wrote:
It looks like the problematic statement is the call the import function here:
__dotnet_replacements.requirePromise = import(/* webpackIgnore: true */'module').then(mod => {
const require = mod.createRequire(import.meta.url);
const path = require('path');
const url = require('url');
__dotnet_replacements.require = require;
__dirname = scriptDirectory = path.dirname(url.fileURLToPath(import.meta.url)) + '/';
return require;
});
It doesn't looks like that code comes from emscripten itself...
So you know if used to work in the past? What version of emscripten did this last work with?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
a.c
a.js
outputs
it looks like acorn is unable to parse
1n
.Quickly glancing at our version usage,
acorn-optimizer.js
does haveecmaVersion: 2020,
but that does not seem to be enough?The text was updated successfully, but these errors were encountered: