Revert unreadable '9e9' and 'if (x > max) max = x;' optimizations from srx/library_gl.js. Regresses hello webgl by 10 bytes (+0.17%)

Author: juj

src/library_gl.js

@@ -252,7 +252,7 @@ var LibraryGL = {
       var source = '';
       for (var i = 0; i < count; ++i) {
         var len = length ? {{{ makeGetValue('length', 'i*4', 'i32') }}} : -1;
-        source += UTF8ToString({{{ makeGetValue('string', 'i*4', 'i32') }}}, len < 0 ? 9e9/*short abbrv. for infinity*/ : len);
+        source += UTF8ToString({{{ makeGetValue('string', 'i*4', 'i32') }}}, len < 0 ? undefined : len);
       }
 #if LEGACY_GL_EMULATION
       // Let's see if we need to enable the standard derivatives extension
@@ -982,10 +982,7 @@ var LibraryGL = {
         var u = GLctx.getActiveUniform(p, i);
 
         var name = u.name;
-        var length = name.length + 1;
-        if (length > ptable.maxUniformLength) {
-          ptable.maxUniformLength = length;
-        }
+        ptable.maxUniformLength = Math.max(ptable.maxUniformLength, name.length+1);
 
         // Strip off any trailing array specifier we might have got, e.g. "[0]".
         var ls = name.lastIndexOf('[');

tests/test_other.py

@@ -8890,8 +8890,8 @@ def test_minimal_runtime_code_size(self):
     test_cases = [
       (asmjs + opts, hello_world_sources, {'a.html': 665, 'a.js': 518,  'a.asm.js': 741, 'a.mem': 6}),
       (opts, hello_world_sources, {'a.html': 623, 'a.js': 624, 'a.wasm': 86}),
-      (asmjs + opts, hello_webgl_sources, {'a.html': 665, 'a.js': 5770, 'a.asm.js': 11361, 'a.mem': 321}),
-      (opts, hello_webgl_sources, {'a.html': 623, 'a.js': 5747, 'a.wasm': 8978})
+      (asmjs + opts, hello_webgl_sources, {'a.html': 665, 'a.js': 5777, 'a.asm.js': 11361, 'a.mem': 321}),
+      (opts, hello_webgl_sources, {'a.html': 623, 'a.js': 5755, 'a.wasm': 8978})
     ]
 
     success = True