Skip to content

Commit a5b2b51

Browse files
aheejinkripken
authored andcommitted
Disable binaryen trap test on Wasm backend (#5877)
* Disable binaryen trap test on Wasm backend After llvm-mirror/llvm@9f86840#diff-15ffc2fb5830c3a8c3c4c354857b1631, LLVM has two behaviors: When executing llc with `-mattr=+nontrapping-fptoint`: It generates nontrapping version of instructions, those with :sat varient. When executing llc with `-mattr=-nontrapping-fptoint`: It generates trapping version of instructions, but it inserts conditional checks around them so they don't trap and clamp to the predefined value. So it seems not very possible to support this trapping test including three modes (allow, trap, and js) for wasm backend now. Related: WebAssembly/binaryen/#1168, #5863
1 parent 28a8b56 commit a5b2b51

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/test_core.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7142,6 +7142,7 @@ def test_binaryen(self):
71427142
self.emcc_args += ['-s', 'BINARYEN=1', '-s', 'BINARYEN_METHOD="interpret-binary"']
71437143
self.do_run(open(path_from_root('tests', 'hello_world.c')).read(), 'hello, world!')
71447144

7145+
@no_wasm_backend('Wasm backend emits non-trapping float-to-int conversion')
71457146
def test_binaryen_trap_mode(self):
71467147
if not self.is_wasm(): return self.skip('wasm test')
71477148
TRAP_OUTPUTS = ('trap', 'RuntimeError')

0 commit comments

Comments
 (0)