Skip to content

Commit 97fa454

Browse files
committed
turn on Firefox OffscreenCanvas support in CircleCI
OffscreenCanvas is behind the gfx.offscreencanvas.enabled preference. The relevant tests are silently reported as ok if the feature is not enabled. Unfortunately, these tests are still skipped because of several bugs.
1 parent 674e729 commit 97fa454

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

.circleci/config.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,10 @@ jobs:
6262
EMCC_CORES=4 python3 emscripten/embuilder.py build ALL
6363
python3 emscripten/tests/runner.py test_hello_world
6464
mkdir tmp-firefox-profile/
65-
echo 'user_pref("javascript.options.shared_memory", true);' >> tmp-firefox-profile/user.js
65+
cat > tmp-firefox-profile/user.js <<EOF
66+
user_pref("gfx.offscreencanvas.enabled", true);
67+
user_pref("javascript.options.shared_memory", true);
68+
EOF
6669
6770
# Set up X and Openbox config (if we move to a headless browser, this may not be needed).
6871
mkdir -p .config/X11
@@ -143,7 +146,11 @@ jobs:
143146
# initial position of the mouse pointer relative to the canvas.
144147
# browser.test_html5_webgl_create_context is skipped because
145148
# anti-aliasing is not well supported.
146-
- TEST_TARGET=browser skip:browser.test_sdl_ttf_render_text_solid skip:browser.test_sdl2_mouse skip:browser.test_html5_webgl_create_context
149+
# browser.test_webgl_offscreen_canvas_in_pthread and
150+
# browser.test_webgl_offscreen_canvas_in_mainthread_after_pthread
151+
# are crashing Firefox (bugzil.la/1281796). The former case is
152+
# further blocked by issue #6897.
153+
- TEST_TARGET=browser skip:browser.test_sdl_ttf_render_text_solid skip:browser.test_sdl2_mouse skip:browser.test_html5_webgl_create_context skip:browser.test_webgl_offscreen_canvas_in_pthread skip:browser.test_webgl_offscreen_canvas_in_mainthread_after_pthread
147154
# TODO: use Firefox headless mode when https://bugzil.la/1375585 resolves
148155
- TEST_DEPENDENCY=dbus-x11 firefox menu openbox xinit xserver-xorg xserver-xorg-video-dummy
149156
- EMSCRIPTEN_BROWSER=firefox -profile tmp-firefox-profile/

0 commit comments

Comments
 (0)