Skip to content

Commit 96606ff

Browse files
authored
fix asmi.test_dlfcn* (which are not tested on the bots) (#6902)
Marking it as ASM_JS=2 tells it that we can't expect asm.js validation to happen, the same as we do in asm0 mode. (The actual failure is that in -O0 we warn on addFunction needing a type param in the wasm backend, and mention that's not an issue in asm.js - but then "asm.js" appears in a warning, and the test runner thinks that might be an asm.js validation error...) Also comment out some unreachable code in SDL, which shows warnings in some JS VMs, which made debugging this issue harder.
1 parent f6e01aa commit 96606ff

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/library_sdl.js

+2
Original file line numberDiff line numberDiff line change
@@ -1779,12 +1779,14 @@ var LibrarySDL = {
17791779
SDL_WarpMouse__sig: 'vii',
17801780
SDL_WarpMouse: function(x, y) {
17811781
return; // TODO: implement this in a non-buggy way. Need to keep relative mouse movements correct after calling this
1782+
/*
17821783
var rect = Module["canvas"].getBoundingClientRect();
17831784
SDL.events.push({
17841785
type: 'mousemove',
17851786
pageX: x + (window.scrollX + rect.left),
17861787
pageY: y + (window.scrollY + rect.top)
17871788
});
1789+
*/
17881790
},
17891791

17901792
SDL_ShowCursor__proxy: 'sync',

tests/test_core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -7891,7 +7891,7 @@ def setUp(self):
78917891
binaryen2_interpret = make_run('binaryen2_interpret', emcc_args=['-O2', '-s', 'BINARYEN_METHOD="interpret-binary"'])
78927892

78937893
# emterpreter
7894-
asmi = make_run('asmi', emcc_args=['-s', 'EMTERPRETIFY=1', '-s', 'WASM=0'])
7894+
asmi = make_run('asmi', emcc_args=['-s', 'ASM_JS=2', '-s', 'EMTERPRETIFY=1', '-s', 'WASM=0'])
78957895
asm2i = make_run('asm2i', emcc_args=['-O2', '-s', 'EMTERPRETIFY=1', '-s', 'WASM=0'])
78967896

78977897
del T # T is just a shape for the specific subclasses, we don't test it itself

0 commit comments

Comments
 (0)