Skip to content

Commit 72fe8a9

Browse files
authored
[test] Remove test/emscripten_log/emscripten_log_with_closure.cpp. NFC (#23592)
This test was added in #5808, but we can do better by just running the entire emscripten_log test in closure.
1 parent 6535fba commit 72fe8a9

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

test/emscripten_log/emscripten_log_with_closure.cpp

Lines changed: 0 additions & 12 deletions
This file was deleted.

test/emscripten_log/emscripten_log_with_closure.out

Lines changed: 0 additions & 1 deletion
This file was deleted.

test/test_core.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7884,11 +7884,9 @@ def test_modularize_closure_pre(self):
78847884
@also_with_wasm_bigint
78857885
def test_emscripten_log(self):
78867886
self.emcc_args += ['-g', '-DRUN_FROM_JS_SHELL', '-Wno-deprecated-pragma']
7887-
self.do_run_in_out_file_test('emscripten_log/emscripten_log.cpp', interleaved_output=False)
7888-
# test closure compiler as well
78897887
if self.maybe_closure():
78907888
self.emcc_args += ['-g1'] # extra testing
7891-
self.do_run_in_out_file_test('emscripten_log/emscripten_log_with_closure.cpp', interleaved_output=False)
7889+
self.do_run_in_out_file_test('emscripten_log/emscripten_log.cpp', interleaved_output=False)
78927890

78937891
def test_float_literals(self):
78947892
self.do_run_in_out_file_test('test_float_literals.cpp')

0 commit comments

Comments
 (0)