fix test

Author: kripken

tests/test_browser.py

@@ -3897,27 +3897,28 @@ def test_unicode_html_shell(self):
     self.run_browser('test.html', None, '/report_result?0')
 
   def test_ENVIRONMENT(self):
-    for work in (1, 0):
-      for assertions in (0, 1):
-        if work and assertions: continue # we care about assertions when we fail
-        # tell the compiler to build with just that engine
-        args = []
-        if work:
-          args += ['-s', 'ENVIRONMENT="web"']
-        else:
-          args += ['-s', 'ENVIRONMENT="node"']
-        if assertions:
-          args += ['-s', 'ASSERTIONS=1']
-        print(work, assertions, args)
-        try:
-          self.btest('browser_test_hello_world.c', expected='0', args=args)
-        except Exception as e:
-          if not work:
-            if assertions:
-              # with assertions, an error should be shown
-              self.assertContained('not compiled with support for that', str(e))
-          else:
-            raise
-        js = open('src.cpp.o.js').read()
-        assert ('require(' in js) == ('node' in str(args)), 'we should have require() calls only if node js specified'
+    # handle when errors occur, report 999
+    open('pre.js', 'w').write('''
+      window.onerror = function(error) {
+        window.onerror = null;
+        var xhr = new XMLHttpRequest();
+        xhr.open('GET', 'http://localhost:8888/report_result?999', true);
+        xhr.send();
+        setTimeout(function() { window.close() }, 1000);
+      }
+    ''')
+    jses = {}
+    for env in ['web', 'node', None]:
+      # tell the compiler to build with just that engine
+      args = ['--pre-js', 'pre.js']
+      if env:
+        args += ['-s', 'ENVIRONMENT="%s"' % env]
+      print(env, args)
+      fail = 'node' in str(args)
+      self.btest('browser_test_hello_world.c', expected='0' if not fail else '999', args=args)
+      js = open('test.js').read()
+      assert ('require(' in js) == fail, 'we should have require() calls only if node js specified'
+      jses[str(env)] = js
+    assert jses['None'] == jses['web'], 'not saying web but html output means web'
+    assert jses['None'] != jses['node'], 'but node leads to different output of course'