Skip to content

Commit 11e3111

Browse files
authored
[test] Enable minimal runtime + asan tests. NFC (#23562)
These seems to pass just find now.
1 parent 1a1c303 commit 11e3111

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@ jobs:
526526
asan.test_externref_emjs_dynlink
527527
asan.test_asyncify_longjmp
528528
asan.test_pthread_run_on_main_thread
529+
asan.test_minimal_runtime_global_initializer
529530
lsan.test_dylink_dso_needed
530531
lsan.test_stdio_locking
531532
lsan.test_dlfcn_basic

test/test_core.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,7 +1022,6 @@ def test_exceptions_off(self):
10221022
self.do_runf('core/test_exceptions.cpp', assert_returncode=NON_ZERO)
10231023

10241024
@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/16816')
1025-
@no_asan('TODO: ASan support in minimal runtime')
10261025
def test_exceptions_minimal_runtime(self):
10271026
self.maybe_closure()
10281027
self.set_setting('MINIMAL_RUNTIME')
@@ -5605,7 +5604,6 @@ def test_utf8_invalid(self, args):
56055604
self.do_runf('test_utf8_invalid.c', 'OK.', emcc_args=args)
56065605

56075606
# Test that invalid character in UTF8 does not cause decoding to crash.
5608-
@no_asan('TODO: ASan support in minimal runtime')
56095607
@parameterized({
56105608
'': [[]],
56115609
'textdecoder': [['-sTEXTDECODER']],
@@ -8621,7 +8619,6 @@ def test_no_declare_asm_module_exports(self):
86218619

86228620
# Tests that building with -sDECLARE_ASM_MODULE_EXPORTS=0 works
86238621
@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/16816')
8624-
@no_asan('TODO: ASan support in minimal runtime')
86258622
def test_minimal_runtime_no_declare_asm_module_exports(self):
86268623
self.set_setting('DECLARE_ASM_MODULE_EXPORTS', 0)
86278624
self.set_setting('WASM_ASYNC_COMPILATION', 0)
@@ -8651,7 +8648,6 @@ def test_minimal_runtime_hello_world(self, args):
86518648
'fs': ('FORCE_FILESYSTEM',),
86528649
'nofs': ('NO_FILESYSTEM',),
86538650
})
8654-
@no_asan('TODO: ASan support in minimal runtime')
86558651
def test_minimal_runtime_hello_printf(self, extra_setting):
86568652
self.set_setting('MINIMAL_RUNTIME')
86578653
self.emcc_args += ['--pre-js', test_file('minimal_runtime_exit_handling.js')]
@@ -8664,7 +8660,7 @@ def test_minimal_runtime_hello_printf(self, extra_setting):
86648660

86658661
# Tests that -sMINIMAL_RUNTIME works well with SAFE_HEAP
86668662
@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/16816')
8667-
@no_asan('TODO: ASan support in minimal runtime')
8663+
@no_asan('SAFE_HEAP cannot be used with ASan')
86688664
def test_minimal_runtime_safe_heap(self):
86698665
self.set_setting('MINIMAL_RUNTIME')
86708666
self.emcc_args += ['--pre-js', test_file('minimal_runtime_exit_handling.js')]
@@ -8678,7 +8674,6 @@ def test_minimal_runtime_safe_heap(self):
86788674

86798675
# Tests global initializer with -sMINIMAL_RUNTIME
86808676
@no_wasmfs('https://github.com/emscripten-core/emscripten/issues/16816')
8681-
@no_asan('TODO: ASan support in minimal runtime')
86828677
def test_minimal_runtime_global_initializer(self):
86838678
self.set_setting('MINIMAL_RUNTIME')
86848679
self.emcc_args += ['--pre-js', test_file('minimal_runtime_exit_handling.js')]
@@ -9365,7 +9360,6 @@ def test_get_exported_function(self):
93659360
self.do_core_test('test_get_exported_function.cpp')
93669361

93679362
# Tests the emscripten_get_exported_function() API.
9368-
@no_asan('TODO: ASan support in minimal runtime')
93699363
def test_minimal_runtime_get_exported_function(self):
93709364
self.set_setting('ALLOW_TABLE_GROWTH')
93719365
self.set_setting('MINIMAL_RUNTIME')

0 commit comments

Comments
 (0)