Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a FS admin I want an easy way to visit the Forest page I have made updates to so that I make sure my updates are correctly loaded/transferred. #641

Open
10 of 12 tasks
ASprinkle opened this issue Mar 20, 2018 · 9 comments
Assignees
Milestone

Comments

@ASprinkle
Copy link

ASprinkle commented Mar 20, 2018

Notes

add link back to the modified forest guidelines page in the confirm alert

Acceptance criteria

  • admin can click once and get to updated forest guidelines page

Tasks

  • design how to present link to the user (shekar)
  • implement the change (shekar)
  • tts approval
  • po approval

Definition of Done

  • Code unit / e2e tested and comply with QWASP
  • No new security vulnerabilities
  • Internal team code review
  • Documentation / readme.md / CircleCI updated
  • Docker updated
  • Compare finished design with mockup
  • Usability tested
@sadlerw
Copy link

sadlerw commented Mar 22, 2018

I would suggest always showing the buy permit button and enabling the route if the user is an admin user and has the forest in their permissions regardless of if the season is open or closed. Then the admin can test the closed season stuff without being logged in, but once logging in they can test permit generation.

@sadlerw
Copy link

sadlerw commented Mar 22, 2018

I think it might be helpful to allow admins the ability to run through pay-gov in master/prod with a fake cc number. If that isn't possible them maybe they should be given a link to display the forest permit svg (similar to print) for inspection without having to go through the pay-gov process.

@ASprinkle
Copy link
Author

I am not sure how pay.gov or the use of the buy permit button comes in to play for this story. I wonder if you're thinking of a different story that we closed that had to do with ensuring updates we made to the printed permit?

@sadlerw
Copy link

sadlerw commented Mar 22, 2018

To verify that the season date changes are reflected on the permit you would need to generate a permit.

@sadlerw sadlerw added this to the Sprint 12 milestone Mar 22, 2018
@shekarpendem
Copy link

@MelissaBraxton @ASprinkle Please see the link back to forest page on both forest season and cutting area dates confirmation messages.
screen shot 2018-03-26 at 3 21 19 pm
screen shot 2018-03-26 at 3 23 56 pm

@ASprinkle
Copy link
Author

Yes! I would like to test it out on staging when ready.

@MelissaBraxton
Copy link

This is looking good!

One minor thing:

I'd suggest changing

  • "Click here to verify the updated information"
    to
  • "Click here to view the updated information"

Verify implies that there's an additional verification step in the process, but what we really want is to give folks a quick route to an optional look at the change that was made.

@sadlerw
Copy link

sadlerw commented Mar 29, 2018

blocking until we can get an admin to usability test this with - if you can help @ASprinkle please?

@ASprinkle
Copy link
Author

@sadlerw I am available to test today, don't think I can set something up today (before sprint review) other option would be to reach out the admins list that @bryanmcfadden has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants