-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIKE: As a member of the public when I am taken to some part of the Christmas tree page, I do not want to wait for a whole page reload so that I can get there quickly. #634
Comments
Load times on the packaged master are still at .7 seconds, so we're wondering if there is any way we can see if there are any quick wins for performance optimization to have a faster load time. |
Is the issue that using the sidebar menu to navigate is reloading the page? Or something else? |
not the side bar, it's when you click on some of the static assets like images (like the trees or maps), an internal link in the page to another part of the page, and also for the homepage load time. |
The internal links that reload the page are due to the link being in markdown and not in an angular template. You'd think that a markdown link like link would work if you had at the target, but angular has broken that, so we are stuck with having to use ui-router tags to do smooth scrolling for internal targets. We might be able to make that work somehow within the markdown processor but it's going to get hacky. |
@lauraGgit The following is a summary of my spike research. Already optimized:
Future optimization suggestions: Enabling AoT will require a refactor of nearly all of our form components. The syntax: form.controls.field_name, or form.get('field_name') will need to be replaced by form['controls'].field_name. Once that refactor is made, in theory AoT compilation should work. Lazy loading modules would be a refactor of the routing so that we load the modules on demand vs. all at once. See example here on implementing lazy-loading components: https://angular-2-training-book.rangle.io/handout/modules/lazy-loading-module.html. In our application, I think the |
Notes
Acceptance criteria
Tasks
Definition of Done
The text was updated successfully, but these errors were encountered: