Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with ClojureScript newer than 1.10.764 #502

Open
Macroz opened this issue Mar 25, 2022 · 3 comments
Open

Fails with ClojureScript newer than 1.10.764 #502

Macroz opened this issue Mar 25, 2022 · 3 comments

Comments

@Macroz
Copy link

Macroz commented Mar 25, 2022

Hello, I tried upgrading project dependencies (in an old project) and looks like the changes in Google Closure used in ClojureScript break lein-cljsbuild version 1.1.8. The last working ClojureScript version seems to be 1.10.764.

Here's one of the traces (latest ClojureScript 1.11.4). I think the in-between versions got some other errors.

$lein cljsbuild once
Compiling ClojureScript...
Execution error (NoSuchMethodError) at com.google.javascript.jscomp.deps.ModuleLoader/createRootPaths (ModuleLoader.java:257).
'java.util.stream.Collector com.google.common.collect.ImmutableSortedSet.toImmutableSortedSet(java.util.Comparator)'

What do you advice? Would this be difficult to fix? If I were to dig around, where should I look? Is it worthwhile? Or perhaps transition to Shadow-CLJS?

@mneise
Copy link
Collaborator

mneise commented Mar 25, 2022

@Macroz Thanks for reporting this! I currently don't have any capacity to work on this, but feel free to dive into this yourself if you are curious. Otherwise, transitioning to shadow-cljs is probably the most sensible choice here, since Thomas Heller is actively maintaining it and done great things with it.

@Macroz
Copy link
Author

Macroz commented Mar 25, 2022

As we are looking into migrating to Shadow-CLJS for convenient npm dependencies, I'll try that option first.

@Macroz
Copy link
Author

Macroz commented Jun 1, 2022

Shadow-CLJS is working for us. I can leave this issue open as it can help someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants