Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.clojure.core.rrb-vector errors #469

Open
brandonbloom opened this issue Aug 16, 2017 · 6 comments
Open

org.clojure.core.rrb-vector errors #469

brandonbloom opened this issue Aug 16, 2017 · 6 comments

Comments

@brandonbloom
Copy link
Contributor

There is a problem compiling with respect to the "ranges" macro, which conflicts with a function name. Building with ClojureScript's public API directly compiles just fine.

clojure.lang.ExceptionInfo: failed compiling file:target/js/clojure/core/rrb_vector/trees.cljs {:file #object[java.io.File 0x6a65daed "target/js/clojure/core/rrb_vector/trees.cljs"]}
....
Caused by: clojure.lang.ArityException: Wrong number of args (1) passed to: nodes/ranges
        at cljs.analyzer$macroexpand_1_STAR_$fn__2179.invoke(analyzer.cljc:2658)
....

See full details in original discussion: brandonbloom/fipp#42

Here's a diff to the RRB vector project that works around this problem: clojure/core.rrb-vector@master...alexandergunnarson:master

@jimrthy
Copy link

jimrthy commented Jan 7, 2018

Just as a data point, I've run into this using boot and adzerk/boot-cljs (switching rrb-vector to use quantum's fork was a viable work-around).

@chadharrington
Copy link

I am hitting this problem, too. Does anyone have a handle on what is needed for a fix in lein-cljsbuild?

@yogthos
Copy link

yogthos commented May 24, 2018

Having this issue as well here reagent-project/reagent-forms#147

@mneise
Copy link
Collaborator

mneise commented Jul 6, 2018

PR welcome. Repo to reproduce this issue can be found here: https://github.com/mneise/cljsbuild-469.

@miikka
Copy link

miikka commented Oct 23, 2018

I investigated this problem a bit since it happens with Doo as well. It happens if the Clojure namespace clojure.core.rrb-vector.nodes gets loaded before the rrb-vector ClojureScript code gets compiled. I don't understand the implementation of lein-cljsbuild very well but I think that it's the use of tools.namespace.repl.reload which causes the namespace to be loaded if it's in the classpath.

Here's a reproduction with cljs.main: https://github.com/miikka/cljs-rrb-vector-repro

@miikka
Copy link

miikka commented Feb 9, 2019

The underlying issue CRRBV-15 has been fixed and a new version of core.rrb-vector with the fix has been released as [org.clojure/core.rrb-vector "0.0.14"]. I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants