Merge branch 'master' into advance-rfc-1046

kategengler · web-flow · commit 046f53122c74 · 2025-03-21T14:23:30.000-04:00
diff --git a/.github/workflows/generate-rfc-frontmatter-json.yml b/.github/workflows/generate-rfc-frontmatter-json.yml
@@ -20,8 +20,9 @@ jobs:
         run: |
           node rfcs-tooling/scripts/list-frontmatter.mjs text/*.md > rfc-data.json
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: rfc-data
           path: rfc-data.json
           if-no-files-found: error
+          overwrite: true
diff --git a/.github/workflows/open-advancement-pr.yml b/.github/workflows/open-advancement-pr.yml
@@ -88,8 +88,9 @@ jobs:
           echo '{ "file": "${{ inputs.rfc-path }}", "number": "${{ inputs.rfc-number }}", "pr": "${{ steps.create-pr.outputs.pull-request-url }}", "advancementStage": "${{ inputs.new-stage }}" }' > advance-rfc-${{ inputs.rfc-number }}.json
 
       - name: Upload artifact of open RFC PRs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: advancement-prs
           path: advance-rfc-${{ inputs.rfc-number }}.json
+          overwrite: true
           if-no-files-found: error
diff --git a/0000-template.md b/0000-template.md
@@ -30,7 +30,8 @@ project-link: Leave as is
 suite: Leave as is
 -->
 
-<-- Replace "RFC title" with the title of your RFC -->
+<!-- Replace "RFC title" with the title of your RFC -->
+
 # RFC title
 
 ## Summary
diff --git a/README.md b/README.md
@@ -119,6 +119,8 @@ Read more about the RFC [Stages].
 ## Stages
 [Stages]: #stages
 
+Here are all the stages that an RFC can be in:
+
 | Stage| Description| Requires FCP to enter? |
 | -----| -----------|----- |
 | [0 - Proposed](#Proposed) | A proposal for a change to Ember or its processes that is offered for community and team evaluation. | no |
diff --git a/text/0724-road-to-typescript.md b/text/0724-road-to-typescript.md
@@ -1,5 +1,5 @@
 ---
-stage: released
+stage: recommended
 start-date: 2021-03-11T00:00:00.000Z
 release-date:
 release-versions:
@@ -13,6 +13,7 @@ prs:
   accepted: 'https://github.com/emberjs/rfcs/pull/724'
   ready-for-release: 'https://github.com/emberjs/rfcs/pull/869'
   released: 'https://github.com/emberjs/rfcs/pull/948'
+  recommended: 'https://github.com/emberjs/rfcs/pull/952'
 project-link:
 ---
 
diff --git a/text/0931-template-compiler-api.md b/text/0931-template-compiler-api.md
@@ -1,17 +1,18 @@
 ---
-stage: accepted
-start-date: 2023-05-31 
-release-date: # In format YYYY-MM-DDT00:00:00.000Z
+stage: ready-for-release
+start-date: 2023-05-31T00:00:00.000Z
+release-date:
 release-versions:
-teams: # delete teams that aren't relevant
+teams:
   - cli
   - data
   - framework
   - learning
   - steering
   - typescript
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/931
+  accepted: 'https://github.com/emberjs/rfcs/pull/931'
+  ready-for-release: 'https://github.com/emberjs/rfcs/pull/933'
 project-link:
 suite:
 ---
diff --git a/text/1001-deprecate-named-inject.md b/text/1001-deprecate-named-inject.md
@@ -1,14 +1,16 @@
 ---
-stage: ready-for-release
+stage: released
 start-date: 2023-12-26T00:00:00.000Z
 release-date:
 release-versions:
+  ember-source: 6.3.0
 teams:
   - framework
   - typescript
 prs:
   accepted: 'https://github.com/emberjs/rfcs/pull/1001'
   ready-for-release: 'https://github.com/emberjs/rfcs/pull/1013'
+  released: 'https://github.com/emberjs/rfcs/pull/1061'
 project-link:
 ---
 
diff --git a/text/1003-deprecation-import-ember-from-ember.md b/text/1003-deprecation-import-ember-from-ember.md
@@ -1,17 +1,18 @@
 ---
-stage: accepted
+stage: ready-for-release
 start-date: 2024-01-22T00:00:00.000Z
 release-date:
 release-versions:
-teams: # delete teams that aren't relevant
+teams:
   - cli
   - data
   - framework
   - learning
   - steering
   - typescript
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/1003 
+  accepted: 'https://github.com/emberjs/rfcs/pull/1003'
+  ready-for-release: 'https://github.com/emberjs/rfcs/pull/1015'
 project-link:
 ---
 
diff --git a/text/1009-move-deprecation-workflow-to-apps.md b/text/1009-move-deprecation-workflow-to-apps.md
@@ -1,18 +1,19 @@
 ---
-stage: accepted
-start-date: 2024-02-22T00:00:00.000Z 
-release-date: # In format YYYY-MM-DDT00:00:00.000Z
+stage: ready-for-release
+start-date: 2024-02-22T00:00:00.000Z
+release-date:
 release-versions:
-teams: # delete teams that aren't relevant
+teams:
   - cli
   - data
   - framework
   - learning
   - typescript
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/1009 
+  accepted: 'https://github.com/emberjs/rfcs/pull/1009'
+  ready-for-release: 'https://github.com/emberjs/rfcs/pull/1048'
 project-link:
-suite: 
+suite:
 ---
 
 <!--- 
diff --git a/text/1029-deprecate-app-prefix.md b/text/1029-deprecate-app-prefix.md
@@ -1,13 +1,14 @@
 ---
-stage: accepted
+stage: ready-for-release
 start-date: 2024-05-20T00:00:00.000Z
 release-date:
 release-versions:
-teams: # delete teams that aren't relevant
+teams:
   - cli
   - learning
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/1029
+  accepted: 'https://github.com/emberjs/rfcs/pull/1029'
+  ready-for-release: 'https://github.com/emberjs/rfcs/pull/1044'
 project-link:
 ---
 
diff --git a/text/1046-template-tag-in-routes.md b/text/1046-template-tag-in-routes.md
@@ -34,7 +34,7 @@ suite: Leave as is
 
 ## Summary
 
-Allow `app/templates/*.hbs` to convert to `app/temlates/*.gjs`.
+Allow `app/templates/*.hbs` to convert to `app/templates/*.gjs`.
 
 ## Motivation
 
@@ -163,7 +163,7 @@ No new typescript-specific features are required. If you're authoring route temp
 
 This RFC was directly inspired by a first attempt at updating the Guides for Template Tag. It became immediately apparent that we can write _much_ clearer guides if we can teach all GJS, instead of a mix of GJS and HBS.
 
-Starting at https://guides.emberjs.com/release/components/ when the first `application.hbs` file is introduced, we would use `.gjs` instead. In those opening examples that are empahsizing HTML, the only change to the content would be wrapping `<template></template>` around the HTML.
+Starting at https://guides.emberjs.com/release/components/ when the first `application.hbs` file is introduced, we would use `.gjs` instead. In those opening examples that are emphasizing HTML, the only change to the content would be wrapping `<template></template>` around the HTML.
 
 Progressing to https://guides.emberjs.com/release/components/introducing-components/, learners extract their first component. It now becomes possible to do that within the same file. This allows teaching fewer things in a single step. First, people can learn what a component is. Second, it can be refactored into a separate file. We can avoid teaching anything about "pascal case" and naming rules, because everything just follows javascript naming rules.
 
diff --git a/text/1055-vanilla-prettier-setup-in-blueprints.md b/text/1055-vanilla-prettier-setup-in-blueprints.md
@@ -1,14 +1,15 @@
 ---
-stage: accepted
+stage: ready-for-release
 start-date: 2024-12-03T00:00:00.000Z
-release-date: 
+release-date:
 release-versions:
 teams:
   - cli
 prs:
-  accepted: https://github.com/emberjs/rfcs/pull/1055
+  accepted: 'https://github.com/emberjs/rfcs/pull/1055'
+  ready-for-release: 'https://github.com/emberjs/rfcs/pull/1063'
 project-link:
-suite: 
+suite:
 ---
 
 # Vanilla Prettier Setup in Blueprints
diff --git a/text/1065-remove-ember-fetch.md b/text/1065-remove-ember-fetch.md
@@ -0,0 +1,151 @@
+---
+stage: accepted
+start-date: 2025-01-10T00:00:00.000Z
+release-date:
+release-versions:
+teams: # delete teams that aren't relevant
+  - cli
+  - data
+  - framework
+  - learning
+prs:
+  accepted: https://github.com/emberjs/rfcs/pull/1065
+project-link:
+---
+
+<!---
+Directions for above:
+
+stage: Leave as is
+start-date: Fill in with today's date, 2032-12-01T00:00:00.000Z
+release-date: Leave as is
+release-versions: Leave as is
+teams: Include only the [team(s)](README.md#relevant-teams) for which this RFC applies
+prs:
+  accepted: Fill this in with the URL for the Proposal RFC PR
+project-link: Leave as is
+-->
+
+# Deprecate and Remove ember-fetch 
+
+## Summary
+
+This RFC proposes removing `ember-fetch` from the blueprint for new projects, and recommends alternative, more native, ways of having "managed fetch".
+
+## Motivation
+
+The package, `ember-fetch`, does a fair bit of deceptive and incorrect behavior that is incompatible with modern JavaScript tooling, such as _being_ `ember-fetch`, yet only importing from `fetch`.
+
+## Transition Path
+
+- Remove ember-fetch from all blueprints
+- Deprecate the npm package and archive the github repo.
+- Migrate to an alternative for "managed fetch" 
+
+### What does `ember-fetch` do?
+
+_Primarily_, it wraps the native `fetch` in `waitForPromise` from `@ember/test-waiters` (aka "settled state integration").
+
+
+Secondarily, but not popularly used, are a series of utilities (e.g.: for checking kinds of errors). These could be copied into projects that use them and modified to fit each project's needs. 
+
+### Using native `fetch`
+
+If you only use `ember-fetch` in route model-hooks, then the settled-state integration isn't used (or rather, you rely on the routing's settled-state integration, and `ember-fetch`'s settled-state integration is extraneous) 
+
+
+### Direct replacement
+
+
+To replace `ember-fetch`'s core-functionality using the least amount of effort involves adding a new utility in `@ember/test-waiters`, `waitForFetch`:
+
+```ts
+// in @ember/test-waiters
+import { waitForPromise } from './wait-for-promise';
+
+export async function waitForFetch<Value>(fetchPromise: Promise<Value>) {
+    waitForPromise(fetchPromise);
+
+    let response = await fetchPromise;
+
+    return new Proxy(response, {
+        get(target, prop, receiver) {
+            let original = Reflect.get(target, prop, receiver);
+
+            if (['json', 'text', 'arrayBuffer', 'blob', 'formData'].includes(prop)) {
+                return (...args) => {
+                    let parsePromise = original.call(target, ...args);
+
+                    return waitForPromise(parsePromise);
+                }
+            }
+
+            return original;
+        }
+    });
+}
+```
+
+
+To have a single import mirroring the behavior of `ember-fetch`, _in full_, folks can still provide a single export that does:
+
+```ts
+import { waitForFetch } from '@ember/test-waiters';
+
+export function wrappedFetch(...args: Parameters<typeof fetch>) {
+    return waitForFetch(fetch(...args));
+}
+```
+
+
+And then throughout your project, you could find and replace all imports of `import fetch from 'fetch';` with `import { wrappedFetch } from 'app-name/utils/wrapped-fetch';`
+
+
+
+### Using a service
+
+Potentially an easier-to-manage implementation uses a service such as the following:
+
+```ts
+import Service from '@ember/service';
+import { waitFor } from '@ember/test-waiters';
+
+export default class Fetch extends Service {
+
+    @waitFor
+    @action
+    requestJson(...args: Parameters<typeof fetch>) {
+        return fetch(...args).then(response => response.json());
+    }
+
+    @waitFor
+    @action
+    requestText(...args: Parameters<typeof fetch>) {
+        return fetch(...args).then(response => response.text());
+    }
+}
+```
+
+### Using warp-drive / ember-data
+
+Docs available on https://github.com/emberjs/data/
+
+## How We Teach This
+
+- Add a deprecation notice to the ember-fetch README
+- Archive the ember-fetch repo
+- Remove ember-fetch from the blueprints
+- Remove ember-fetch from the guides (only one reference per version)
+
+## Drawbacks
+
+- if we keep ember-fetch is not compatible with modern tooling and modern SSR approaches
+
+## Alternatives
+
+- n/a
+- ask folks to wrap and proxy fetch themselves
+
+## Unresolved questions
+
+none
diff --git a/text/1068-tracked-collections.md b/text/1068-tracked-collections.md
diff --git a/text/1070-default-globals-for-strict-mode.md b/text/1070-default-globals-for-strict-mode.md
diff --git a/text/1075-warp-drive-package-unification.md b/text/1075-warp-drive-package-unification.md
